~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH aerc] parse: remove trailing whitespace from rfc1123z regex

Details
Message ID
<20220820042910.2186237-1-tom@tjf.sh>
DKIM signature
missing
Download raw message
Patch: +1 -1
When there is no Date header in a message, aerc falls back to the
Received header and tries to extract an rfc1123z date from it
(introduced in commit d1600e46). The current regex for extracting the
date incorrectly allows for trailing whitespace, causing time.Parse() to
fail inside of parseReceivedHeader(). As a result, the message's date is
shown as "???????????????????" in the message list and as
"0000-12-31 07:03 PM" in the message view (the latter is likely related
to the zero value of time.Time).

Steps to reproduce:
1) Send yourself a message with no Date header, e.g. with msmtp:
printf 'Subject: foo bar\n\nbody text\n' | msmtp --set-date-header=off me@example.com
2) Note the message's displayed date in aerc's message list and message
   view.

Signed-off-by: Thomas Faughnan <tom@tjf.sh>
---
 worker/lib/parse.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/worker/lib/parse.go b/worker/lib/parse.go
index 7f6eb20..30d06a9 100644
--- a/worker/lib/parse.go
+++ b/worker/lib/parse.go
@@ -19,7 +19,7 @@ import (
// RFC 1123Z regexp
var dateRe = regexp.MustCompile(`(((Mon|Tue|Wed|Thu|Fri|Sat|Sun))[,]?\s[0-9]{1,2})\s` +
	`(Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec)\s` +
	`([0-9]{4})\s([0-9]{2}):([0-9]{2})(:([0-9]{2}))?\s([\+|\-][0-9]{4})\s?`)
	`([0-9]{4})\s([0-9]{2}):([0-9]{2})(:([0-9]{2}))?\s([\+|\-][0-9]{4})`)

func FetchEntityPartReader(e *message.Entity, index []int) (io.Reader, error) {
	if len(index) == 0 {
-- 
2.37.1

[aerc/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CMAKPUAIXLJ4.3EXXG34NG278V@cirno2>
In-Reply-To
<20220820042910.2186237-1-tom@tjf.sh> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: FAILED in 2m25s

[parse: remove trailing whitespace from rfc1123z regex][0] from [Thomas Faughnan][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/34801
[1]: tom@tjf.sh

✓ #827200 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/827200
✗ #827199 FAILED  aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/827199
Details
Message ID
<CMAONLK2JFLQ.1DTFIV1X9O1YM@Archetype>
In-Reply-To
<20220820042910.2186237-1-tom@tjf.sh> (view parent)
DKIM signature
missing
Download raw message
Hi, please send your patch as UTF-8.
Reply to thread Export thread (mbox)