~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH aerc] changelog: reword before release

Details
Message ID
<20230827165908.658737-2-robin@jarry.cc>
DKIM signature
missing
Download raw message
Patch: +14 -16
Use similar writing mood than other versions.

Signed-off-by: Robin Jarry <robin@jarry.cc>
---
We should clarify what kind of style we want in the change log. This is
not the same as git commit messages.

 CHANGELOG.md   | 28 +++++++++++++---------------
 doc/aerc.1.scd |  2 +-
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ae5b98f6224e..c3e216405095 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,26 +7,24 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Added

- The new account wizard now supports all source and outgoing backends.
- Add a `-A` option to `:save` for saving all the named parts, not just
  attachments
- Add `<Backspace>` key to bindings
- Colorize can style diff chunk function names with `diff_chunk_func`.
- Warn before sending emails with an empty subject with `empty-subject-warning`
  in `aerc.conf`.
- IMAP now uses the delimiter advertised by the server
- Completions for `:mkdir`
- `carddav-query` utility to use for `address-book-cmd`.
- JMAP support.
- Folder name mapping with `folder-map` in `accounts.conf`.
- Add option `-d` to `:open` to automatically delete temporary files.
- The new account wizard now supports all source and outgoing backends.
- Edit email headers directly in the text editor with `[compose].edit-headers`
  in `aerc.conf` or with the `-e` flag for all compose related commands (e.g.
  `:compose`, `:forward`, `:recall`, etc.).
- Use `:save -A` to save all the named parts, not just attachments.
- The `<Backspace>` key can now be bound.
- `colorize` can style diff chunk function names with `diff_chunk_func`.
- Warn before sending emails with an empty subject with `empty-subject-warning`
  in `aerc.conf`.
- IMAP now uses the delimiter advertised by the server.
- `carddav-query` utility to use for `address-book-cmd`.
- Folder name mapping with `folder-map` in `accounts.conf`.
- Use `:open -d` to automatically delete temporary files.
- Remove headers from the compose window with `:header -d <name>`.
- Add option `-r` to `:attach` to pipe the attachments in.
- Add `msglist_gutter` and `msglist_pill` styles for message list scrollbar.
- Add `%f` placeholder to `file-picker-cmd` which expands to a location of a
- `:attach -r <name> <cmd>` to pipe the attachments from a command.
- New `msglist_gutter` and `msglist_pill` styles for message list scrollbar.
- New `%f` placeholder to `file-picker-cmd` which expands to a location of a
  temporary file from which selected files will be read instead of the standard
  output.

diff --git a/doc/aerc.1.scd b/doc/aerc.1.scd
index ecaedfd69d0b..640d551e7a0b 100644
--- a/doc/aerc.1.scd
+++ b/doc/aerc.1.scd
@@ -572,7 +572,7 @@ message list, the message in the message viewer, etc).
	message is immediately discarded.

*:attach* _<path>_++
*:attach* *-m* [_<arg>_]
*:attach* *-m* [_<arg>_]++
*:attach* *-r* <name> <cmd>
	Attaches the file at the given path to the email. The path can contain
	globbing syntax described at https://godocs.io/path/filepath#Match.
-- 
2.41.0

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CV3HRV2QH4G6.3P9O7RYDQALYL@cirno2>
In-Reply-To
<20230827165908.658737-2-robin@jarry.cc> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 5m35s

[changelog: reword before release][0] from [Robin Jarry][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/44047
[1]: robin@jarry.cc

✓ #1048368 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1048368
✓ #1048367 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1048367
Details
Message ID
<CVN16LVVWYDE.2V7Y5SWOMJ4AJ@poldrack.dev>
In-Reply-To
<20230827165908.658737-2-robin@jarry.cc> (view parent)
DKIM signature
missing
Download raw message
On Sun Aug 27, 2023 at 6:59 PM CEST, Robin Jarry wrote:
> Use similar writing mood than other versions.

* as other versions.

>
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---
> We should clarify what kind of style we want in the change log. This is
> not the same as git commit messages.
>
>  CHANGELOG.md   | 28 +++++++++++++---------------
>  doc/aerc.1.scd |  2 +-

Not sure this was intentional, but I'm fine with it staying.

>  2 files changed, 14 insertions(+), 16 deletions(-)
>

Otherwise:

Reviewed-by: Moritz Poldrack <moritz@poldrack.dev>

-- 
Moritz Poldrack
https://moritz.sh

> Exact change only.
Details
Message ID
<CVN75CS8X5N5.MPN4DLP1RWKP@ringo>
In-Reply-To
<CVN16LVVWYDE.2V7Y5SWOMJ4AJ@poldrack.dev> (view parent)
DKIM signature
missing
Download raw message
Moritz Poldrack, Sep 19, 2023 at 18:23:
> On Sun Aug 27, 2023 at 6:59 PM CEST, Robin Jarry wrote:
> > Use similar writing mood than other versions.
>
> * as other versions.
>
> >
> > Signed-off-by: Robin Jarry <robin@jarry.cc>
> > ---
> > We should clarify what kind of style we want in the change log. This is
> > not the same as git commit messages.
> >
> >  CHANGELOG.md   | 28 +++++++++++++---------------
> >  doc/aerc.1.scd |  2 +-
>
> Not sure this was intentional, but I'm fine with it staying.

It wasn't, I did split it into a separate commit. Nice catch.

> Otherwise:
>
> Reviewed-by: Moritz Poldrack <moritz@poldrack.dev>

Applied. Thanks!
Reply to thread Export thread (mbox)