~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH aerc] split: remove previous split from grid

Details
Message ID
<20230912145532.48876-2-tim@timculverhouse.com>
DKIM signature
missing
Download raw message
Patch: +1 -0
Remove the previous split from the account grid view. When adding a new
child at an existing location, the content is appended to a slice
instead of replacing any old values. The old content must be explicitly
removed.

Reported-by: inwit <inwit@sindominio.net>
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 widgets/account.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/widgets/account.go b/widgets/account.go
index b5c71c297e73..7c4a5e17d4df 100644
--- a/widgets/account.go
+++ b/widgets/account.go
@@ -541,6 +541,7 @@ func (acct *AccountView) updateSplitView(msg *models.MessageInfo) {
	}
	fn := func() {
		if acct.split != nil {
			acct.grid.RemoveChild(acct.split)
			acct.split.Close()
		}
		lib.NewMessageStoreView(msg, false, acct.Store(), acct.aerc.Crypto, acct.aerc.DecryptKeys,
-- 
2.42.0

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CVH1206B5D0N.2CKJ0TK5DVPRG@cirno2>
In-Reply-To
<20230912145532.48876-2-tim@timculverhouse.com> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 4m51s

[split: remove previous split from grid][0] from [Tim Culverhouse][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/44607
[1]: tim@timculverhouse.com

✓ #1056666 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1056666
✓ #1056665 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1056665
Details
Message ID
<CVH1665OOOU6.3Q9AU2RWMSS3S@poldrack.dev>
In-Reply-To
<20230912145532.48876-2-tim@timculverhouse.com> (view parent)
DKIM signature
missing
Download raw message
Reviewed-by: Moritz Poldrack <moritz@poldrack.dev>
-- 
Moritz Poldrack
https://moritz.sh

> Offer limited to residents of the contiguous United States.
Details
Message ID
<CVMAANMCDPCR.GYKXBL319HD@ringo>
In-Reply-To
<CVH1665OOOU6.3Q9AU2RWMSS3S@poldrack.dev> (view parent)
DKIM signature
missing
Download raw message
Moritz Poldrack, Sep 12, 2023 at 17:07:
> Reviewed-by: Moritz Poldrack <moritz@poldrack.dev>

Acked-by: Robin-Jarry <robin@jarry.cc>

Applied. Thanks!
Reply to thread Export thread (mbox)