~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH aerc] commands: remove compose commands from message viewer

Details
Message ID
<20240208224303.1232644-2-robin@jarry.cc>
DKIM signature
pass
Download raw message
Patch: +1 -1
All compose commands were made available in the message viewer context
by mistake. Remove them.

This fixes a crash when the :send command is invoked while viewing
a message:

Fixes: 159fb38daf53 ("commands: refactor registration")
Fixes: https://lists.sr.ht/~rjarry/aerc-devel/%3CCZ01NTGWNUBV.14A9POG9ITJ6F%40posteo.net%3E
Reported-by: Sertonix <sertonix@posteo.net>
Signed-off-by: Robin Jarry <robin@jarry.cc>
---
 commands/commands.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/commands.go b/commands/commands.go
index b617bade2cb7..951d5fdceeed 100644
--- a/commands/commands.go
+++ b/commands/commands.go
@@ -46,7 +46,7 @@ func CurrentContext() CommandContext {
	case *app.Composer:
		context |= COMPOSE
	case *app.MessageViewer:
		context |= COMPOSE | MESSAGE | MESSAGE_VIEWER
		context |= MESSAGE | MESSAGE_VIEWER
	case *app.Terminal:
		context |= TERMINAL
	}
-- 
2.43.0

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CZ02927UYGYZ.39I5U13ZF8EWP@fra01>
In-Reply-To
<20240208224303.1232644-2-robin@jarry.cc> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 1m53s

[commands: remove compose commands from message viewer][0] from [Robin Jarry][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/49303
[1]: robin@jarry.cc

✓ #1146234 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1146234
✓ #1146233 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1146233

Re: [aerc/patches] build success

Maarten Aertsen <maarten@nlnetlabs.nl>
Details
Message ID
<CZBVTLDW5FQ0.3PL1WY227RLWK@nlnetlabs.nl>
In-Reply-To
<CZ02927UYGYZ.39I5U13ZF8EWP@fra01> (view parent)
DKIM signature
pass
Download raw message
Tested-by: Maarten Aertsen <maarten@nlnetlabs.nl>
Details
Message ID
<CZBXDPR22J72.M0RAPMB7BJNR@ringo>
In-Reply-To
<20240208224303.1232644-2-robin@jarry.cc> (view parent)
DKIM signature
pass
Download raw message
Maarten Aertsen, Feb 22, 2024 at 21:15:
> Robin Jarry, Feb 08, 2024 at 23:43:
> > All compose commands were made available in the message viewer context
> > by mistake. Remove them.
> >
> > This fixes a crash when the :send command is invoked while viewing
> > a message:
> >
> > Fixes: 159fb38daf53 ("commands: refactor registration")
> > Fixes: https://lists.sr.ht/~rjarry/aerc-devel/%3CCZ01NTGWNUBV.14A9POG9ITJ6F%40posteo.net%3E
> > Reported-by: Sertonix <sertonix@posteo.net>
> > Signed-off-by: Robin Jarry <robin@jarry.cc>
> > ---
>
> Tested-by: Maarten Aertsen <maarten@nlnetlabs.nl>

Applied. Thanks!
Reply to thread Export thread (mbox)