This reverts commit d73cf33c2c6c3e564ce8aff04acc329a06eafc54.
This breaks virtually all key bindings on foot. Almost zero ctrl-
bindings work, and even in some cases, single key binds, like n don't
register anymore.
It looked harmless, but I should probably have tested before applying
this.
Signed-off-by: Robin Jarry <robin@jarry.cc>
---
lib/ui/ui.go | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/ui/ui.go b/lib/ui/ui.go
index 43545197778e..d63ebf36c4ca 100644
--- a/lib/ui/ui.go+++ b/lib/ui/ui.go
@@ -49,7 +49,8 @@ var state struct {
func Initialize(content DrawableInteractive) error {
opts := vaxis.Options{
- DisableMouse: !config.Ui.MouseEnabled,+ DisableMouse: !config.Ui.MouseEnabled,+ DisableKittyKeyboard: true, }
vx, err := vaxis.New(opts)
if err != nil {
--
2.43.0
On Mon, 19 Feb 2024 14:28:24 CST, Robin Jarry wrote:
> This reverts commit d73cf33c2c6c3e564ce8aff04acc329a06eafc54.> > This breaks virtually all key bindings on foot. Almost zero ctrl-> bindings work, and even in some cases, single key binds, like n don't> register anymore.> > It looked harmless, but I should probably have tested before applying> this.> > Signed-off-by: Robin Jarry <robin@jarry.cc>> ---
As discussed on IRC, we need to do some more work to match against the extra
modifiers we see with Kitty enabled (num_lock, in this case).
Acked-by: Tim Culverhouse <tim@timculverhouse.com>
Tim Culverhouse, Feb 19, 2024 at 22:28:
> On Mon, 19 Feb 2024 14:28:24 CST, Robin Jarry wrote:> > This reverts commit d73cf33c2c6c3e564ce8aff04acc329a06eafc54.> > > > This breaks virtually all key bindings on foot. Almost zero ctrl-> > bindings work, and even in some cases, single key binds, like n don't> > register anymore.> > > > It looked harmless, but I should probably have tested before applying> > this.> > > > Signed-off-by: Robin Jarry <robin@jarry.cc>> > --->> As discussed on IRC, we need to do some more work to match against the extra> modifiers we see with Kitty enabled (num_lock, in this case).>> Acked-by: Tim Culverhouse <tim@timculverhouse.com>
Applied. Thanks!