~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH aerc] revert: "ui: enable kitty keyboard protocol"

Details
Message ID
<20240219202815.332645-1-robin@jarry.cc>
DKIM signature
pass
Download raw message
Patch: +2 -1
This reverts commit d73cf33c2c6c3e564ce8aff04acc329a06eafc54.

This breaks virtually all key bindings on foot. Almost zero ctrl-
bindings work, and even in some cases, single key binds, like n don't
register anymore.

It looked harmless, but I should probably have tested before applying
this.

Signed-off-by: Robin Jarry <robin@jarry.cc>
---
 lib/ui/ui.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/ui/ui.go b/lib/ui/ui.go
index 43545197778e..d63ebf36c4ca 100644
--- a/lib/ui/ui.go
+++ b/lib/ui/ui.go
@@ -49,7 +49,8 @@ var state struct {

func Initialize(content DrawableInteractive) error {
	opts := vaxis.Options{
		DisableMouse: !config.Ui.MouseEnabled,
		DisableMouse:         !config.Ui.MouseEnabled,
		DisableKittyKeyboard: true,
	}
	vx, err := vaxis.New(opts)
	if err != nil {
-- 
2.43.0

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CZ9C9O3H9HBB.25C25L6OAIDVJ@fra01>
In-Reply-To
<20240219202815.332645-1-robin@jarry.cc> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 2m21s

[revert: "ui: enable kitty keyboard protocol"][0] from [Robin Jarry][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/49683
[1]: robin@jarry.cc

✓ #1153640 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1153640
✓ #1153641 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1153641
Details
Message ID
<7ef9d2a0-41a3-4a48-9849-b767db17035d@sloti42n25>
In-Reply-To
<20240219202815.332645-1-robin@jarry.cc> (view parent)
DKIM signature
pass
Download raw message
On Mon, 19 Feb 2024 14:28:24 CST, Robin Jarry wrote:
> This reverts commit d73cf33c2c6c3e564ce8aff04acc329a06eafc54.
> 
> This breaks virtually all key bindings on foot. Almost zero ctrl-
> bindings work, and even in some cases, single key binds, like n don't
> register anymore.
> 
> It looked harmless, but I should probably have tested before applying
> this.
> 
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---

As discussed on IRC, we need to do some more work to match against the extra
modifiers we see with Kitty enabled (num_lock, in this case).

Acked-by: Tim Culverhouse <tim@timculverhouse.com>
Details
Message ID
<CZ9DMO6B16C4.1RWQIGUIVVLIL@ringo>
In-Reply-To
<7ef9d2a0-41a3-4a48-9849-b767db17035d@sloti42n25> (view parent)
DKIM signature
pass
Download raw message
Tim Culverhouse, Feb 19, 2024 at 22:28:
> On Mon, 19 Feb 2024 14:28:24 CST, Robin Jarry wrote:
> > This reverts commit d73cf33c2c6c3e564ce8aff04acc329a06eafc54.
> > 
> > This breaks virtually all key bindings on foot. Almost zero ctrl-
> > bindings work, and even in some cases, single key binds, like n don't
> > register anymore.
> > 
> > It looked harmless, but I should probably have tested before applying
> > this.
> > 
> > Signed-off-by: Robin Jarry <robin@jarry.cc>
> > ---
>
> As discussed on IRC, we need to do some more work to match against the extra
> modifiers we see with Kitty enabled (num_lock, in this case).
>
> Acked-by: Tim Culverhouse <tim@timculverhouse.com>

Applied. Thanks!
Reply to thread Export thread (mbox)