~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH aerc] ui: update vaxis and only use disambiguate csi-u flag

Details
Message ID
<20240223203735.55140-2-tim@timculverhouse.com>
DKIM signature
pass
Download raw message
Patch: +4 -3
Update vaxis to 0.8.0, which adds the ability to specify any CSI-u flag
combination. Explicitly only use the disambiguate flag. This enables
aerc to have additional keybinds not previously possible (C-i, C-m)
while preventing some internal logic bugs relating to single-modifier
key presses. While these events can be useful, they are not needed in
aerc and aerc currently would need several workarounds to properly
handle them so let's just not request them in the first place.

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 go.mod       | 2 +-
 go.sum       | 4 ++--
 lib/ui/ui.go | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/go.mod b/go.mod
index 47825168fe51..e014d1dac45e 100644
--- a/go.mod
+++ b/go.mod
@@ -5,7 +5,7 @@ go 1.18
require (
	git.sr.ht/~rjarry/go-opt v1.3.0
	git.sr.ht/~rockorager/go-jmap v0.4.5
	git.sr.ht/~rockorager/vaxis v0.7.4
	git.sr.ht/~rockorager/vaxis v0.8.0
	github.com/ProtonMail/go-crypto v0.0.0-20230417170513-8ee5748c52b5
	github.com/arran4/golang-ical v0.0.0-20230318005454-19abf92700cc
	github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964
diff --git a/go.sum b/go.sum
index 381107319f65..369c807dd5b8 100644
--- a/go.sum
+++ b/go.sum
@@ -2,8 +2,8 @@ git.sr.ht/~rjarry/go-opt v1.3.0 h1:9BLOcXi5OhDYVzH3Td48i2uM/byMGNqXY7YhBzvEZg8=
git.sr.ht/~rjarry/go-opt v1.3.0/go.mod h1:oEPZUTJKGn1FVye0znaLoeskE/QTuyoJw5q+fjusdM4=
git.sr.ht/~rockorager/go-jmap v0.4.5 h1:ab/2+voWrR2/ej4l9GtsyyycK5lOgUMfGSFgNny3Q0c=
git.sr.ht/~rockorager/go-jmap v0.4.5/go.mod h1:aOTCtwpZSINpDDSOkLGpHU0Kbbm5lcSDMcobX3ZtOjY=
git.sr.ht/~rockorager/vaxis v0.7.4 h1:aGTzn0Z7DFNQzoqoyUAHhmHI4pgimjfIaEIfE7lQKHA=
git.sr.ht/~rockorager/vaxis v0.7.4/go.mod h1:h94aKek3frIV1hJbdXjqnBqaLkbWXvV+UxAsQHg9bns=
git.sr.ht/~rockorager/vaxis v0.8.0 h1:tzVvLNJ71N1iRpwlxmU0PW7IRuglqw7zNbGOk5hq2+k=
git.sr.ht/~rockorager/vaxis v0.8.0/go.mod h1:h94aKek3frIV1hJbdXjqnBqaLkbWXvV+UxAsQHg9bns=
github.com/ProtonMail/crypto v0.0.0-20200420072808-71bec3603bf3 h1:JW27/kGLQzeM1Fxg5YQhdkTEAU7HIAHMgSag35zVTnY=
github.com/ProtonMail/crypto v0.0.0-20200420072808-71bec3603bf3/go.mod h1:Pxr7w4gA2ikI4sWyYwEffm+oew1WAJHzG1SiDpQMkrI=
github.com/ProtonMail/go-crypto v0.0.0-20211112122917-428f8eabeeb3/go.mod h1:z4/9nQmJSSwwds7ejkxaJwO37dru3geImFUdJlaLzQo=
diff --git a/lib/ui/ui.go b/lib/ui/ui.go
index 3b1050b544da..8cc797b24b33 100644
--- a/lib/ui/ui.go
+++ b/lib/ui/ui.go
@@ -50,6 +50,7 @@ var state struct {
func Initialize(content DrawableInteractive) error {
	opts := vaxis.Options{
		DisableMouse: !config.Ui.MouseEnabled,
		CSIuBitMask:  vaxis.CSIuDisambiguate,
	}
	vx, err := vaxis.New(opts)
	if err != nil {
-- 
2.43.2

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CZCQZ7F5SWTW.1QWS5C2EVM6HG@fra01>
In-Reply-To
<20240223203735.55140-2-tim@timculverhouse.com> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 2m22s

[ui: update vaxis and only use disambiguate csi-u flag][0] from [Tim Culverhouse][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/49769
[1]: tim@timculverhouse.com

✓ #1156321 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1156321
✓ #1156320 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1156320
Details
Message ID
<CZCR07BMWBW4.3EA1EW6WFMPMS@jasoncarloscox.com>
In-Reply-To
<20240223203735.55140-2-tim@timculverhouse.com> (view parent)
DKIM signature
pass
Download raw message
On Fri Feb 23, 2024 at 3:37 PM EST, Tim Culverhouse wrote:
> Update vaxis to 0.8.0, which adds the ability to specify any CSI-u flag
> combination. Explicitly only use the disambiguate flag. This enables
> aerc to have additional keybinds not previously possible (C-i, C-m)
> while preventing some internal logic bugs relating to single-modifier
> key presses. While these events can be useful, they are not needed in
> aerc and aerc currently would need several workarounds to properly
> handle them so let's just not request them in the first place.

This patch fixes the plus bind issue I reported in IRC. Thanks!

Tested-by: Jason Cox <me@jasoncarloscox.com>
Details
Message ID
<CZEUKJBHXK8M.1BYS6NZV4521Y@sindominio.net>
In-Reply-To
<CZCR07BMWBW4.3EA1EW6WFMPMS@jasoncarloscox.com> (view parent)
DKIM signature
pass
Download raw message
Fixes my "tS" binding too!

Tested-By: inwit <inwit@sindominio.net>
Reply to thread Export thread (mbox)