~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 4

[PATCH aerc] imap: drain updates channel when moving messages

Details
Message ID
<20240226205211.192205-1-koni.marti@gmail.com>
DKIM signature
pass
Download raw message
Patch: +3 -0
Drain the updates channel when moving messages to prevent a backend
freeze. This also fixes a possible freeze for large-scale archive
operations since the archive command uses the move operation.

Reported-by: Moritz Poldrack <moritz@poldrack.dev>
Signed-off-by: Koni Marti <koni.marti@gmail.com>
---
 worker/imap/movecopy.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/worker/imap/movecopy.go b/worker/imap/movecopy.go
index d3df133a..58357a45 100644
--- a/worker/imap/movecopy.go
+++ b/worker/imap/movecopy.go
@@ -48,6 +48,9 @@ func (imapw *IMAPWorker) handleAppendMessage(msg *types.AppendMessage) {
}

func (imapw *IMAPWorker) handleMoveMessages(msg *types.MoveMessages) {
	drain := imapw.drainUpdates()
	defer drain.Close()

	uids := toSeqSet(msg.Uids)
	if err := imapw.client.UidMove(uids, msg.Destination); err != nil {
		imapw.worker.PostMessage(&types.Error{
-- 
2.44.0

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CZFB5RAXIOO0.3P4AONVP3CKQD@fra02>
In-Reply-To
<20240226205211.192205-1-koni.marti@gmail.com> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 2m13s

[imap: drain updates channel when moving messages][0] from [Koni Marti][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/49815
[1]: koni.marti@gmail.com

✓ #1157737 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1157737
✓ #1157738 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1157738
Details
Message ID
<CZFBLR4GNIIA.1BGHF4I82BKSQ@poldrack.dev>
In-Reply-To
<20240226205211.192205-1-koni.marti@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Works like a charm

Tested-by: Moritz Poldrack <moritz@poldrack.dev>

-- 
Moritz Poldrack
https://moritz.sh

> Booths for two or more.
Details
Message ID
<CZFC4L0WFONB.ACP8EF4S76Q9@disroot.org>
In-Reply-To
<20240226205211.192205-1-koni.marti@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Works great, thank you!

Tested-by: Jeremy Baxter <jtbx@disroot.org>

Applied: [PATCH aerc] imap: drain updates channel when moving messages

Details
Message ID
<170898656617.317414.3241361902918325724@ringo>
In-Reply-To
<20240226205211.192205-1-koni.marti@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Koni Marti <koni.marti@gmail.com> wrote:
> Drain the updates channel when moving messages to prevent a backend
> freeze. This also fixes a possible freeze for large-scale archive
> operations since the archive command uses the move operation.
>
> Reported-by: Moritz Poldrack <moritz@poldrack.dev>
> Signed-off-by: Koni Marti <koni.marti@gmail.com>
> ---

Acked-by: Robin Jarry <robin@jarry.cc>

Applied, thanks.

To git@git.sr.ht:~rjarry/aerc
   8543aec8f12c..66bbc5303578  master -> master
Reply to thread Export thread (mbox)