Signed-off-by: quaff <me@quaff.ca>
---
Done! I've made the requested changes to the first patch.
integrations/pgp.md | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/integrations/pgp.md b/integrations/pgp.md
index 2e826ef0..494e61cc 100644
--- a/integrations/pgp.md+++ b/integrations/pgp.md
@@ -34,3 +34,12 @@ following commands:
gpg --export >> ~/.local/share/aerc/keyring.asc
gpg --export-secret-keys >> ~/.local/share/aerc/keyring.asc
```
++## Using `aerc` with GnuPG over SSH++If you've tried to integrate GnuPG with aerc over SSH, you might have+encountered an issue where pinentry fails to function properly. This occurs+because pinentry lacks control over the tty while aerc maintains control.++For guidance on resolving this, you may find assistance in the following+Arch Linux wiki page: [Forwarding gpg-agent and ssh-agent to remote](https://wiki.archlinux.org/title/GnuPG#Forwarding_gpg-agent_and_ssh-agent_to_remote).
--
2.44.0
On Mon Mar 25, 2024 at 19:56, quaff <me@quaff.ca> wrote:
> Signed-off-by: quaff <me@quaff.ca>> ---> Done! I've made the requested changes to the first patch.>> integrations/pgp.md | 9 +++++++++> 1 file changed, 9 insertions(+)>> diff --git a/integrations/pgp.md b/integrations/pgp.md> index 2e826ef0..494e61cc 100644> --- a/integrations/pgp.md> +++ b/integrations/pgp.md> @@ -34,3 +34,12 @@ following commands:> gpg --export >> ~/.local/share/aerc/keyring.asc> gpg --export-secret-keys >> ~/.local/share/aerc/keyring.asc> ```> +> +## Using `aerc` with GnuPG over SSH> +> +If you've tried to integrate GnuPG with aerc over SSH, you might have> +encountered an issue where pinentry fails to function properly. This occurs> +because pinentry lacks control over the tty while aerc maintains control.> +> +For guidance on resolving this, you may find assistance in the following> +Arch Linux wiki page: [Forwarding gpg-agent and ssh-agent to remote](https://wiki.archlinux.org/title/GnuPG#Forwarding_gpg-agent_and_ssh-agent_to_remote).
Acked-by: Bence Ferdinandy <bence@ferdinandy.com>
--
+36305425054
bence.ferdinandy.com
quaff, Mar 25, 2024 at 19:57:
> Signed-off-by: quaff <me@quaff.ca>> ---> Done! I've made the requested changes to the first patch.
Hi,
I have a few remarks:
Please read CONTRIBUTING.md :)
- Write something in the commit body [1].
- Use imperative mood [2].
- Use --subject-prefix="PATCH aerc/wiki" [3].
[1] https://git.sr.ht/~rjarry/aerc/tree/master/item/CONTRIBUTING.md?view-source#L33-36
[2] https://git.sr.ht/~rjarry/aerc/tree/master/item/CONTRIBUTING.md?view-source#L38-40
[3] https://git.sr.ht/~rjarry/aerc/tree/master/item/CONTRIBUTING.md?view-source#L118-122
Could you shorten the commit title? E.g.:
"integrations: mention gpg-agent for use over ssh"
NB: your patch is for the wiki branch. The "docs: " prefix is redundant
and does not bring any meaningful context. It would be like using the
"aerc: " prefix for the master branch. "integrations: " seems more
suitable and informative in this case.
> diff --git a/integrations/pgp.md b/integrations/pgp.md> index 2e826ef0..494e61cc 100644> --- a/integrations/pgp.md> +++ b/integrations/pgp.md> @@ -34,3 +34,12 @@ following commands:> gpg --export >> ~/.local/share/aerc/keyring.asc> gpg --export-secret-keys >> ~/.local/share/aerc/keyring.asc> ```> +> +## Using `aerc` with GnuPG over SSH> +> +If you've tried to integrate GnuPG with aerc over SSH, you might have> +encountered an issue where pinentry fails to function properly. This occurs> +because pinentry lacks control over the tty while aerc maintains control.> +> +For guidance on resolving this, you may find assistance in the following> +Arch Linux wiki page: [Forwarding gpg-agent and ssh-agent to remote](https://wiki.archlinux.org/title/GnuPG#Forwarding_gpg-agent_and_ssh-agent_to_remote).
In order to shorten this line, can you move the url target to a separate
link definition? E.g.:
> Arch Linux wiki page: [Forwarding gpg-agent and ssh-agent to remote][arch].>> [arch]: https://wiki.archlinux.org/title/GnuPG#Forwarding_gpg-agent_and_ssh-agent_to_remote
Thanks.