~rjarry/aerc-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH aerc] jmap: fix message list order direction

Details
Message ID
<20240605143031.110700-2-robin@jarry.cc>
DKIM signature
pass
Download raw message
Patch: +1 -1
Since the update to go-jmap 0.5.0, the IsAscending property is now taken
into account even if it is false.

The initial JMAP implementation wrongfully assumed the behaviour and
inverted the sort -r logic. Fix that so that messages are ordered as
expected.

Link: https://git.sr.ht/~rockorager/go-jmap/commit/1db959676c10398a8
Signed-off-by: Robin Jarry <robin@jarry.cc>
---
 worker/jmap/directories.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/worker/jmap/directories.go b/worker/jmap/directories.go
index 2b25397583db..66875cc75a53 100644
--- a/worker/jmap/directories.go
+++ b/worker/jmap/directories.go
@@ -349,7 +349,7 @@ func translateSort(criteria []*types.SortCriterion) []*email.SortComparator {
		default:
			continue
		}
		cmp.IsAscending = !s.Reverse
		cmp.IsAscending = s.Reverse
		sort = append(sort, &cmp)
	}

-- 
2.45.1

[aerc/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D1S5O14LEH3C.V1A8VN9HHNHB@fra01>
In-Reply-To
<20240605143031.110700-2-robin@jarry.cc> (view parent)
DKIM signature
missing
Download raw message
aerc/patches: SUCCESS in 1m58s

[jmap: fix message list order direction][0] from [Robin Jarry][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/53144
[1]: robin@jarry.cc

✓ #1243047 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1243047
✓ #1243046 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1243046
Details
Message ID
<D1S5O6KVFX1J.53PCGALGTEZB@timculverhouse.com>
In-Reply-To
<20240605143031.110700-2-robin@jarry.cc> (view parent)
DKIM signature
pass
Download raw message
On Wed Jun 5, 2024 at 9:31 AM CDT, Robin Jarry wrote:
> Since the update to go-jmap 0.5.0, the IsAscending property is now taken
> into account even if it is false.
>
> The initial JMAP implementation wrongfully assumed the behaviour and
> inverted the sort -r logic. Fix that so that messages are ordered as
> expected.
>
> Link: https://git.sr.ht/~rockorager/go-jmap/commit/1db959676c10398a8
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---

Tested-by: Tim Culverhouse <tim@timculverhouse.com>
Details
Message ID
<D1S7E3PVYSLD.2OOR2UB0BDMVR@ringo>
In-Reply-To
<D1S5O6KVFX1J.53PCGALGTEZB@timculverhouse.com> (view parent)
DKIM signature
pass
Download raw message
Tim Culverhouse, Jun 05, 2024 at 16:33:
> On Wed Jun 5, 2024 at 9:31 AM CDT, Robin Jarry wrote:
> > Since the update to go-jmap 0.5.0, the IsAscending property is now taken
> > into account even if it is false.
> >
> > The initial JMAP implementation wrongfully assumed the behaviour and
> > inverted the sort -r logic. Fix that so that messages are ordered as
> > expected.
> >
> > Link: https://git.sr.ht/~rockorager/go-jmap/commit/1db959676c10398a8
> > Signed-off-by: Robin Jarry <robin@jarry.cc>
> > ---
>
> Tested-by: Tim Culverhouse <tim@timculverhouse.com>

Applied. Thanks!
Reply to thread Export thread (mbox)