On Mon Jun 17, 2024 at 5:04 PM CEST, Tim Culverhouse wrote:
> Fixes several behind the scenes issues, but notably addresses scrolling> of CJK characters in the terminal widget as well as wrapping of wide> characters>> Reported-by: Tianhao Wang <shrik3@mailbox.org>> Reported-by: ~runxiyu> Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>> ---> v3: Fix an issue v0.9.1 created regarding wrapping of text >> go.mod | 2 +-> go.sum | 4 ++--> 2 files changed, 3 insertions(+), 3 deletions(-)>> diff --git a/go.mod b/go.mod> index e95e4c0c1dc9..660e1b02af69 100644> --- a/go.mod> +++ b/go.mod> @@ -5,7 +5,7 @@ go 1.18> require (> git.sr.ht/~rjarry/go-opt v1.4.0> git.sr.ht/~rockorager/go-jmap v0.5.0> - git.sr.ht/~rockorager/vaxis v0.8.5> + git.sr.ht/~rockorager/vaxis v0.9.2> github.com/ProtonMail/go-crypto v1.0.0> github.com/arran4/golang-ical v0.2.7> github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964> diff --git a/go.sum b/go.sum> index f9a7cc3d6e1f..72e2a427930b 100644> --- a/go.sum> +++ b/go.sum> @@ -2,8 +2,8 @@ git.sr.ht/~rjarry/go-opt v1.4.0 h1:YHUKRXOuoy6d57Jt2b0DRSLbxq0mz5biq+6P/npFK5s=> git.sr.ht/~rjarry/go-opt v1.4.0/go.mod h1:oEPZUTJKGn1FVye0znaLoeskE/QTuyoJw5q+fjusdM4=> git.sr.ht/~rockorager/go-jmap v0.5.0 h1:Xs8NeqpA631HUz4uIe6V+0CpWt6b+nnHF7S14U2BVPA=> git.sr.ht/~rockorager/go-jmap v0.5.0/go.mod h1:aOTCtwpZSINpDDSOkLGpHU0Kbbm5lcSDMcobX3ZtOjY=> -git.sr.ht/~rockorager/vaxis v0.8.5 h1:9R8P6n05wuk9+SoA11Wo+yI18L2/qPYjWmWdvctWF6k=> -git.sr.ht/~rockorager/vaxis v0.8.5/go.mod h1:h94aKek3frIV1hJbdXjqnBqaLkbWXvV+UxAsQHg9bns=> +git.sr.ht/~rockorager/vaxis v0.9.2 h1:OKPaCG3S4b6jWnwUPC0zX+Zw16hhLcSgC2mLw/nwsV0=> +git.sr.ht/~rockorager/vaxis v0.9.2/go.mod h1:h94aKek3frIV1hJbdXjqnBqaLkbWXvV+UxAsQHg9bns=> github.com/ProtonMail/go-crypto v0.0.0-20230923063757-afb1ddc0824c/go.mod h1:EjAoLdwvbIOoOQr3ihjnSoLZRtE8azugULFRteWMNc0=> github.com/ProtonMail/go-crypto v1.0.0 h1:LRuvITjQWX+WIfr930YHG2HNfjR1uOfyf5vE0kC2U78=> github.com/ProtonMail/go-crypto v1.0.0/go.mod h1:EjAoLdwvbIOoOQr3ihjnSoLZRtE8azugULFRteWMNc0=
Thanks! This fixes broken CJK text, however hindi is still ghosting (but
perhaps that's different issue), could you reproduce with the following
Lorem ipsum?
screenshot:
https://0x0.st/XTHr.png
पढाए हिंदी रहारुप अनुवाद कार्यलय मुख्य संस्था सोफ़तवेर निरपेक्ष उनका आपके बाटते आशाआपसमुख्यतह उश
की करता। शुरुआत संस्था कुशलता मेंभटृ अनुवाद गएआप विशेष सकते परिभाषित लाभान्वित प्रतिदेकर समजते
दिशामे प्राप्त जैसे वर्णन संस्थान निर्माता प्रव्रुति भाति चुनने उपलब्ध बेंगलूर अर्थपुर्ण
Tested-by: Tianhao Wang <shrik3@mailbox.org>
cheers,
wth
On Mon Jun 17, 2024 at 12:51 PM CDT, Tianhao Wang wrote:
>> पढाए हिंदी रहारुप अनुवाद कार्यलय मुख्य संस्था सोफ़तवेर निरपेक्ष उनका आपके बाटते आशाआपसमुख्यतह उश> की करता। शुरुआत संस्था कुशलता मेंभटृ अनुवाद गएआप विशेष सकते परिभाषित लाभान्वित प्रतिदेकर समजते> दिशामे प्राप्त जैसे वर्णन संस्थान निर्माता प्रव्रुति भाति चुनने उपलब्ध बेंगलूर अर्थपुर्ण>>> Tested-by: Tianhao Wang <shrik3@mailbox.org>>> cheers,> wth
Thanks for testing - I can definitely reproduce this one. I'll look into it
tomorrow.
--
Tim
On Mon Jun 17, 2024 at 12:51 PM CDT, Tianhao Wang wrote:
> पढाए हिंदी रहारुप अनुवाद कार्यलय मुख्य संस्था सोफ़तवेर निरपेक्ष उनका आपके बाटते आशाआपसमुख्यतह उश> की करता। शुरुआत संस्था कुशलता मेंभटृ अनुवाद गएआप विशेष सकते परिभाषित लाभान्वित प्रतिदेकर समजते> दिशामे प्राप्त जैसे वर्णन संस्थान निर्माता प्रव्रुति भाति चुनने उपलब्ध बेंगलूर अर्थपुर्ण
I can't seem to get much to agree on how long these strings should be. The
top line measured in a few different ways:
Golang (uniseg): 80 columns
Golang (wcwidth): 95 columns
Golang (ignore ZWJ): 80 columns
Zig (zg): 63 columns
Alacritty (??): 80 columns
Ghostty (handrolled): 68 columns
Kitty (wcswidth): 68 columns
Foot (utf8proc): 80 columns
There's no clear consensus nor shared feature for how to decide how to measure
it. I think the best we can do is provide a keybind to do a complete repaint of
the screen for if these characters end up duplicated.
Anyone else have any ideas??
--
Tim
2024. jún. 18. 18:53:27 Tim Culverhouse <tim@timculverhouse.com>:
> On Mon Jun 17, 2024 at 12:51 PM CDT, Tianhao Wang wrote:>> पढाए हिंदी रहारुप अनुवाद कार्यलय मुख्य संस्था सोफ़तवेर निरपेक्ष उनका >> आपके बाटते आशाआपसमुख्यतह उश>> की करता। शुरुआत संस्था कुशलता मेंभटृ अनुवाद गएआप विशेष सकते परिभाषित >> लाभान्वित प्रतिदेकर समजते>> दिशामे प्राप्त जैसे वर्णन संस्थान निर्माता प्रव्रुति भाति चुनने उपलब्ध >> बेंगलूर अर्थपुर्ण>> I can't seem to get much to agree on how long these strings should be. > The> top line measured in a few different ways:>> Golang (uniseg): 80 columns> Golang (wcwidth): 95 columns> Golang (ignore ZWJ): 80 columns> Zig (zg): 63 columns> Alacritty (??): 80 columns> Ghostty (handrolled): 68 columns> Kitty (wcswidth): 68 columns> Foot (utf8proc): 80 columns
The median seems to be 80.
>> There's no clear consensus nor shared feature for how to decide how to > measure> it. I think the best we can do is provide a keybind to do a complete > repaint of> the screen for if these characters end up duplicated.
A repaint ability might be useful anyway, _stuff_ can happen anytime :)
The problem here is that you sort of need to guess what the host terminal
will do?
>> Anyone else have any ideas??
Send the above text to all the above projects and ask them to figure it
out 🤣
>> --> Tim
Tim Culverhouse <tim@timculverhouse.com> wrote:
> Fixes several behind the scenes issues, but notably addresses scrolling> of CJK characters in the terminal widget as well as wrapping of wide> characters>> Reported-by: Tianhao Wang <shrik3@mailbox.org>> Reported-by: ~runxiyu> Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>> ---> v3: Fix an issue v0.9.1 created regarding wrapping of text
Acked-by: Robin Jarry <robin@jarry.cc>
Applied, thanks.
To git@git.sr.ht:~rjarry/aerc
910bc95af6e8..159746ff9ed9 master -> master
