Authentication-Results: mail-b.sr.ht; dkim=pass header.d=timculverhouse.com header.i=@timculverhouse.com; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mail-b.sr.ht (Postfix) with ESMTPS id 9D12F11EEE2 for <~rjarry/aerc-devel@lists.sr.ht>; Sun, 10 Jul 2022 05:25:45 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7570A5C00C8; Sun, 10 Jul 2022 01:25:45 -0400 (EDT) Received: from imap42 ([10.202.2.92]) by compute5.internal (MEProxy); Sun, 10 Jul 2022 01:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= timculverhouse.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm1; t=1657430745; x=1657517145; bh=W37sIhsHo5g/4HfaOYO7HaER7 1nwW3Rz/T58dt1Cszs=; b=BuKnyBVJMmI2LA4HsolEOBUdaDaT/iTMef+csJhuF ZDWBR3lHkobFbS2iZbgcykedocwsK6OMB3yvdq3biMwvrLpZpSCUXHVAbwfbEieC pokAyhwJgpthFsl47Q5gpbCZyCKo/LZWstSR0ne1ZKg4r/oGeaGeNwnz1FcyVKAb 7bN6pj7wXhY05BTu7tkQSAZiJQwSvK3O7na5VEU5ORiG9LbHGO9PzaRAG0vZnM0v x6iD5czYle2QyDXR3sGcQXUBv3v8Az4rkf8iS/ixgMKtv6uMKH9E4QI2NbE+Rgyl bwM0EMgPDGi8eLmTLmf3asqO5EVzey2ZbVpTzvmfoAG2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1657430745; x=1657517145; bh=W 37sIhsHo5g/4HfaOYO7HaER71nwW3Rz/T58dt1Cszs=; b=MI6Pe+HeFpZEDXJhc SXUfqjSKCQcJWvS0y8Ic885D977Xi4HqRBw095eGCLbcNRe1oQtJTa7W0ADRRkBP CXZ180oEB4OPz6Qs/QdnS/WAG9dG/BqIY9c/xFwJ097oyXPHho3fyM8E3p1bvm9s icEC91pt61dOU9P9Oo/3+lB8fvK0Ozla4oBN0k56tgqmqFbGcbUo9w+KTa1n9aOB ETaDqXhO2HPFlB+nlCH6YPn8IQ7UOyUh1uGh5afPzkPDXKyLEAnCVThLXb2fQQqD OjFmtTz7EtkCZj3PSHy5gWuysTtX6D9TNKJvnQigUwDzYJ7L+6P3xrjUXsdgAqzg 5JF4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejtddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtgfesth hqredtreerjeenucfhrhhomhepfdfvihhmucevuhhlvhgvrhhhohhushgvfdcuoehtihhm sehtihhmtghulhhvvghrhhhouhhsvgdrtghomheqnecuggftrfgrthhtvghrnheptdehve dvieekieehvedtueevudegvdegtdeigfevfefhveeifffgueetgeehvefgnecuffhomhgr ihhnpehsrhdrhhhtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhimhesthhimhgtuhhlvhgvrhhhohhushgvrdgtohhm X-ME-Proxy: Feedback-ID: i3ad947a1:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 02C92BC0073; Sun, 10 Jul 2022 01:25:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-720-gbf5afa95ff-fm-20220708.001-gbf5afa95 Mime-Version: 1.0 Message-Id: <6010ddbb-acfb-4806-b7a3-b04f4c633024@beta.fastmail.com> In-Reply-To: References: <20220705060618.68685-1-falsifian@falsifian.org> Date: Sun, 10 Jul 2022 00:25:24 -0500 From: "Tim Culverhouse" To: "James Cook" , ~rjarry/aerc-devel@lists.sr.ht Subject: Re: [PATCH aerc] Allow not marking viewed messages as seen. Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable > Looking at that IMAP RFC link, I think the right thing to do is to fet= ch > BODY.PEEK instead of BODY. Maybe aerc could always fetch BODY.PEEK > instead of BOD, so setting \Seen is always deliberate. I've never > written code that speaks IMAP so take this all with a grain of salt. (I > see "BODY.PEEK" appears in isync's source [0] though I haven't looked > carefully.) I think all that=E2=80=99s needed would be to set {section}.Peek =3D tru= e in worker/imap/fetch.go [0]. You could add a field to the FetchBodyPart and FetchFullMessage messages= which tells the worker what the users config value is for peek. Good find! https://git.sr.ht/~rjarry/aerc/tree/master/item/worker/imap/fetch.go