MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 20 Jan 2022 16:15:28 +0100
Message-Id: <CHALM9X28E4H.3OLX0N86GHC1T@zoidberg>
Subject: Re: [PATCH aerc v2] maildir: pass in-memory message to callback
Cc: 
To: "Robin Jarry" <robin@jarry.cc>, =?utf-8?q?Nguy=E1=BB=85n_Gia_Phong?=
 <mcsinyx@disroot.org>, <~rjarry/aerc-devel@lists.sr.ht>
From: "Sebastien Binet" <s@sbinet.org>
References: <20220120133629.311485-1-mcsinyx@disroot.org>
 <CHAJY2M8IPPG.1IU5AI9W1K78K@zoidberg> <CHAKFIVG30IM.1UA73DAJMZ995@diabtop>
In-Reply-To: <CHAKFIVG30IM.1UA73DAJMZ995@diabtop>

On Thu Jan 20, 2022 at 15:19 CET, Robin Jarry wrote:
> Sebastien Binet, Jan 20, 2022 at 14:56:
> > just a drive-by comment: I don't know what's the policy w/ rjarry/aerc
> > with regard to supported Go versions (so please take the following
> > with a grain of salt), but shouldn't we limit our use of deprecated
> > packages? (io/ioutil is deprecated since ~1.15, IIRC)
> >
> > ie: shouldn't this read:
> > b, err :=3D io.ReadAll(r)
> >
> > instead?
>
> Good point. However, io.ReadAll seems only available since Go 1.16 which
> is not even one year old.
>
> https://pkg.go.dev/io#ReadAll
>
> I am all for avoiding deprecated API. But let's give some more time
> before breaking support for older go toolchains.

IIRC, the Go project only supports the last 2 released versions.
Most of the Go projects I work (eg: Gonum) follow this lead.

I think we'd probably need to clarify this and clearly define somewhere
the policy aerc wants to follow in that regard.
right now, it seems to be "whatever Go version comes with Alpine/edge"
(if .build.yml is any witness).

Either way, I am fine with the decision.

-s