~rjarry/aerc-devel

5 2

panic when shell exits in :term tab

Details
Message ID
<CJ2I45HMOTGD.2J1QMEJ4T1E3N@t450.arielp.com>
DKIM signature
missing
Download raw message
To reproduce:  
	1. Open a terminal tab in aerc (:term)
	2. type 'exit' to close the shell
	3. aerc crashes (SIGSEGV)

aerc 0.9.0-17-g2fd9cef
OpenBSD 7.1-beta (GENERIC.MP) #445: Mon Mar 28 10:37:41 MDT 2022
The shell is OpenBSD's ksh.

The generated log file is attached.  Not sure what else to include here,
so please ask if you would like more info. 

Thank you,

--
Ariel
Details
Message ID
<CJ2KR0D9AKQL.2G0KI08Z01KNX@Archetype>
In-Reply-To
<CJ2I45HMOTGD.2J1QMEJ4T1E3N@t450.arielp.com> (view parent)
DKIM signature
missing
Download raw message
On Tue Apr 5, 2022 at 8:01 PM CEST, Ariel Popper wrote:
> To reproduce:
> 	1. Open a terminal tab in aerc (:term)
> 	2. type 'exit' to close the shell
> 	3. aerc crashes (SIGSEGV)

Is this reproducible? I can't seem to reproduce it on my end with
anything I try.

> aerc 0.9.0-17-g2fd9cef
> OpenBSD 7.1-beta (GENERIC.MP) #445: Mon Mar 28 10:37:41 MDT 2022
> The shell is OpenBSD's ksh.
>
> The generated log file is attached.  Not sure what else to include here,
> so please ask if you would like more info.

Thanks, that's pretty helpful actually. The issue is caused by this
line[0] in the dependency. Can you try updating the dep to v1.1.18 on
your end and see if it still happens? If you can't I can send you a
patch that updates the dependency for trying it out.

[0]: https://github.com/creack/pty/blob/b135084511330383e4d0adc4504cf407cab59bb0/run.go#L58

--
Moritz Poldrack
https://moritz.sh
Details
Message ID
<CJ2QK6GZVU9Z.5ZYP4P7H1TSQ@t450.arielp.com>
In-Reply-To
<CJ2KR0D9AKQL.2G0KI08Z01KNX@Archetype> (view parent)
DKIM signature
missing
Download raw message
> Thanks, that's pretty helpful actually. The issue is caused by this
> line[0] in the dependency. Can you try updating the dep to v1.1.18 on
> your end and see if it still happens? If you can't I can send you a
> patch that updates the dependency for trying it out.
>
> [0]: https://github.com/creack/pty/blob/b135084511330383e4d0adc4504cf407cab59bb0/run.go#L58
>

Yep I was able to update pty to v1.1.18 and it seems to fix the crash.

Thank you for your help.

__
Ariel
Details
Message ID
<CJ2RGFTWWUTR.387W3E3GQ40XW@t450.arielp.com>
In-Reply-To
<CJ2KR0D9AKQL.2G0KI08Z01KNX@Archetype> (view parent)
DKIM signature
missing
Download raw message
It seems I spoke too soon, new crash log attached.

--
Ariel
Details
Message ID
<CJ2Y4CDN9A9D.3SH5SA1SHLF0I@Archetype>
In-Reply-To
<CJ2RGFTWWUTR.387W3E3GQ40XW@t450.arielp.com> (view parent)
DKIM signature
missing
Download raw message
On Wed Apr 6, 2022 at 3:20 AM CEST, Ariel Popper wrote:
> It seems I spoke too soon, new crash log attached.

Can you submit an issue on their bugtracker? We can easily put some
band-aid on it, but that's not really a solution.
Details
Message ID
<CJ3D069RCTXL.3VEZ7JIGFHOHK@Archetype>
In-Reply-To
<CJ2RGFTWWUTR.387W3E3GQ40XW@t450.arielp.com> (view parent)
DKIM signature
missing
Download raw message
I have opened an issue on their GitHub[0], let's see if we can get you a
fix.

[0]: https://github.com/creack/pty/issues/146

--
Moritz Poldrack
https://moritz.sh
Reply to thread Export thread (mbox)