Authentication-Results: mail-b.sr.ht; dkim=pass header.d=timculverhouse.com header.i=@timculverhouse.com; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25])
	by mail-b.sr.ht (Postfix) with ESMTPS id 4B9DD11EF1E
	for <~rjarry/aerc-devel@lists.sr.ht>; Fri,  8 Jul 2022 17:57:48 +0000 (UTC)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailout.nyi.internal (Postfix) with ESMTP id 16D175C01D1;
	Fri,  8 Jul 2022 13:57:48 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
  by compute4.internal (MEProxy); Fri, 08 Jul 2022 13:57:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	timculverhouse.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:references:reply-to:sender
	:subject:subject:to:to; s=fm1; t=1657303068; x=1657389468; bh=s6
	GGGTXE1ikKq6pgO3i133jg9FluEVToSPqOxaeOUok=; b=s0Rji2vUh9Ky81baRF
	p6Qt9WCU+CRBZHGgDU8E8c7DJuCb8kIqVDJNGJ03YK6gFz8GGofkY/yHqCJZtCRh
	tFdZWI51HdMeo6Dbsi7CHjdYZE7HKRLLdC3TK1eSblHfn4YzvhtAW1UTtwMK939f
	pTo1NgpgpTbB+b8V+bEbAaAeHEEdTRGfDk2dlCwDpFXKJPpahgSDVyPxq1T5+E7U
	Dt3z0qRXHt4xQwAbkfsIfmv1yXTvhtXW0boGKgI87bM7OtHeA/Xl8RgCv7cck+ma
	hMoDn+kfB7R21go5TavULlR4aLE8equS345RR6s/krrBE159yvrUSEg2CV9FlLn+
	Mz0A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:references:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
	1657303068; x=1657389468; bh=s6GGGTXE1ikKq6pgO3i133jg9FluEVToSPq
	OxaeOUok=; b=MSUwaM1nL0xBIKg5MQ/b8TkmAensk09p2OcaXNbN/rcp0IJlEnT
	nGdT2R6Ugzq7RXVUonGbJywcfk0AJS/9vvVbU3XIBc6z/laVWWm0mZKomYfcXOoJ
	TpBlzRTL4eiTigAUvOn7O9YY/jLbxaHhyv9e8/4OMEIjwJ0+ss+P1XCfy4ROUGRb
	zHRaqZD+F2hHNwxuAkU9mablUDgeYRTTlu43NMNTALvssPSspw9DM0MxAHj1FgZO
	TpQUyRUv94J0oE7rcOyLVjXtymfMBe4lgVHxy5zGAOKOtIGGk/Y1AEQ7xs2FlMEr
	Sb6zuKtk04In6VuqiJsPW9Ol71Z7izJytGQ==
X-ME-Sender: <xms:G3DIYp91HKimzv259kfFclJK5EA9DS71mE-izDgpq_S3_Nia1_Gtww>
    <xme:G3DIYtsKVb47sztC5xcPxoiPYjLV-PG-loobSL7YQHICQqTGvnBDN3dDqUfsIt13T
    Vygwf1PBmlRMZk9hCY>
X-ME-Received: <xmr:G3DIYnC5OlW9eRpnyg26V6Gbr8HZnlqN3wlUV09YJij31zIU5I0WbanCXSafXNRuuPgcYm5SldwPgL4rImo8puByCN2aPw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddulecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecunecujfgurheptgfuhffvfffkofhfjgevsehgtd
    erreertdejnecuhfhrohhmpedfvfhimhcuvehulhhvvghrhhhouhhsvgdfuceothhimhes
    thhimhgtuhhlvhgvrhhhohhushgvrdgtohhmqeenucggtffrrghtthgvrhhnpeeihefghe
    fftdffhfeujeevueffjeeuhfevgedthefgvdekiedtgffgffdtteduvdenucffohhmrghi
    nhepshhrrdhhthdpihgvthhfrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg
    hrrghmpehmrghilhhfrhhomhepthhimhesthhimhgtuhhlvhgvrhhhohhushgvrdgtohhm
X-ME-Proxy: <xmx:G3DIYtcAv2RqWepMBfQCIA_CoPvkpJE8iZhRNfwMWFbc8AvTXJrqcw>
    <xmx:G3DIYuNJjPQYQK7EZfcH22g_AbJy6XGf8ek4_zdSS_sQxZLh1i4zcA>
    <xmx:G3DIYvkDSKJUsDYjtKlkwaNF20HHSMlogfKMFarIAYw76fbLCGjVVQ>
    <xmx:HHDIYoWUO_uTqA4zfwtKN_Ih1lSCyLjOOsqrJEIqE1ZS__S2Kymwrg>
Feedback-ID: i3ad947a1:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 8 Jul 2022 13:57:47 -0400 (EDT)
Content-Type: multipart/signed;
 boundary=42015a9a785b0d7c119fdb1a51459fc8a0ed19734693e2ed29d6ee5758e3;
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Sourcehut-Patchset-Update: NEEDS-REVISION
Subject: Re: [PATCH aerc] Allow not marking viewed messages as seen.
From: "Tim Culverhouse" <tim@timculverhouse.com>
To: "James Cook" <falsifian@falsifian.org>, <~rjarry/aerc-devel@lists.sr.ht>
Date: Fri, 08 Jul 2022 12:57:44 -0500
Message-Id: <CLAGWLDXIV6M.2KH3WJUCNXDRM@TimBook-Arch>
X-Mailer: aerc 0.10.0-55-g97a20fc
References: <20220705060618.68685-1-falsifian@falsifian.org>
In-Reply-To: <20220705060618.68685-1-falsifian@falsifian.org>
Cc: 

--42015a9a785b0d7c119fdb1a51459fc8a0ed19734693e2ed29d6ee5758e3
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Tue Jul 5, 2022 at 1:06 AM CDT, James Cook wrote:
> Fixes: https://todo.sr.ht/~rjarry/aerc/48
> Signed-off-by: James Cook <falsifian@falsifian.org>

Thanks for the patch James! I tested this on imap, maildir, and notmuch
backends. It works as expected for maildir and notmuch.

The imap backend still marks the messages as read, however. The issue is
that imap servers set the \Seen flag when any part of the body is
fetched (see https://datatracker.ietf.org/doc/html/rfc3501#section-6.4.5)

I suspect we'll need to remove the flag after fetching for imap
backends.

The rest looked good to me!

Tim

--42015a9a785b0d7c119fdb1a51459fc8a0ed19734693e2ed29d6ee5758e3
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEPEbs97ymvqQFTi1YPNHFcmbSSHIFAmLIcBsACgkQPNHFcmbS
SHJYRw/9EhbGhWW/pWrJtOyXlvC3H16cxLdv4MEot3SPeewLHazKRn4bx40nEmpD
050POlS8doZ5kCXhVx7IDTx6xGEMoAzbinOggGC/k1Mh7gf/Y8yZkyjsEDr6e97r
nROLGbr3r+IZfLeTDfvMLQDN94Kj5fUKh44FD0INYDR2vGdQK+ZCznbgQRoVkxg6
8GfPSrmzq1fhpN9sT8RpHV3BQlViJ4M4ZKn4+C0lnFGAqJWPw8Jmnvk1DdTyItGQ
vCPg28pCRv8mkBFnAQc9HwApu1pTwEJBKCxSM+dvv1TBuwqEZy3M1lRruTxVjWhs
+D5mEqYzZ8taJWn4arXqROtEyl62DHrNe7Pner8/n8qXddIk3hXAHamJLMIu7+kV
Pu1RFZaykWpmToXRE6HjU9Oi49ugqzM5p5dK+1ppSjJg3ySdgVqNeCuNVPiA9zfa
5frg2B/Py92t+if3tqtXutz34qSQ9PupFYkWIh1XSnSxFfv2JvRM1g8fcsMAMnmp
OpIAtzf0tujHp/G4/WKZBO2tiSBgweIOZikb55qklvQesobVgt4+phF9mjuchviQ
983C8wH0BQ2jYvnjq28RigmarAT6o3sB49Kl6zmH+UwRlw4T8ufiIsfY2fqFuz3u
axIxVUMHR2gtZI8x7qgtDc7YiwGSOSl4pXPLnGQ1nzoI5zESJL4=
=/quN
-----END PGP SIGNATURE-----

--42015a9a785b0d7c119fdb1a51459fc8a0ed19734693e2ed29d6ee5758e3--