Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 10 Jul 2022 01:48:16 +0000
Message-Id: <CLBLJEF0Y8M8.37UIZII0LE4TG@moth.falsifian.org>
Subject: Re: [PATCH aerc] Allow not marking viewed messages as seen.
From: "James Cook" <falsifian@falsifian.org>
To: "Tim Culverhouse" <tim@timculverhouse.com>,
 <~rjarry/aerc-devel@lists.sr.ht>
References: <20220705060618.68685-1-falsifian@falsifian.org>
 <CLAGWLDXIV6M.2KH3WJUCNXDRM@TimBook-Arch>
In-Reply-To: <CLAGWLDXIV6M.2KH3WJUCNXDRM@TimBook-Arch>
Cc: 

On Fri Jul 8, 2022 at 5:57 PM UTC, Tim Culverhouse wrote:
> On Tue Jul 5, 2022 at 1:06 AM CDT, James Cook wrote:
> > Fixes: https://todo.sr.ht/~rjarry/aerc/48
> > Signed-off-by: James Cook <falsifian@falsifian.org>
>
> Thanks for the patch James! I tested this on imap, maildir, and notmuch
> backends. It works as expected for maildir and notmuch.
>
> The imap backend still marks the messages as read, however. The issue is
> that imap servers set the \Seen flag when any part of the body is
> fetched (see https://datatracker.ietf.org/doc/html/rfc3501#section-6.4.5)
>
> I suspect we'll need to remove the flag after fetching for imap
> backends.
>
> The rest looked good to me!
>
> Tim

Thanks for testing it!

Looking at that IMAP RFC link, I think the right thing to do is to fetch
BODY.PEEK instead of BODY. Maybe aerc could always fetch BODY.PEEK
instead of BOD, so setting \Seen is always deliberate. I've never
written code that speaks IMAP so take this all with a grain of salt. (I
see "BODY.PEEK" appears in isync's source [0] though I haven't looked
carefully.)

FYI I've been using this patch with aerc's notmuch backend since I sent
it, and haven't had any trouble.

--=20
James

[0] https://sourceforge.net/p/isync/isync/ci/master/tree/src/drv_imap.c