Content-Type: multipart/signed;
 boundary=58bca13e9fed0ff8a213980dc0929e454b7afe73bd76e8170030deca3d04;
 micalg=pgp-sha256; protocol="application/pgp-signature"
To: "James Cook" <falsifian@falsifian.org>, "Tim Culverhouse"
 <tim@timculverhouse.com>, <~rjarry/aerc-devel@lists.sr.ht>
Subject: Re: [PATCH aerc] Allow not marking viewed messages as seen.
From: "Moritz Poldrack" <moritz@poldrack.dev>
Date: Sun, 10 Jul 2022 10:18:45 +0200
Message-Id: <CLBTUDQ29NM8.1Q41X548XI78B@Archetype>
References: <20220705060618.68685-1-falsifian@falsifian.org>
 <CLAGWLDXIV6M.2KH3WJUCNXDRM@TimBook-Arch>
 <CLBLJEF0Y8M8.37UIZII0LE4TG@moth.falsifian.org>
In-Reply-To: <CLBLJEF0Y8M8.37UIZII0LE4TG@moth.falsifian.org>
Cc: 

--58bca13e9fed0ff8a213980dc0929e454b7afe73bd76e8170030deca3d04
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Sun Jul 10, 2022 at 3:48 AM CEST, James Cook wrote:
> Looking at that IMAP RFC link, I think the right thing to do is to fetch
> BODY.PEEK instead of BODY. Maybe aerc could always fetch BODY.PEEK
> instead of BOD, so setting \Seen is always deliberate.
I'd argue that BODY is the correct way to handle it and rather remove
the \Seen flag when requested. aerc is a mail client for which this
behaviour is the expected in most cases.

> I've never written code that speaks IMAP so take this all with a grain
> of salt. (I see "BODY.PEEK" appears in isync's source [0] though I
> haven't looked carefully.)
I think this is due to isync having a completely different purpose from
aerc. isync indiscriminately downloads all mail and would thereby mess
up the \Seen flags for all messages.

> FYI I've been using this patch with aerc's notmuch backend since I sent
> it, and haven't had any trouble.
I think having this flag only work for maildir and notmuch backends
would be fine. If IMAP is something you want to support, I'd suggest
removing the \Seen after fetching the mail.

--=20
Moritz Poldrack
https://moritz.sh

--58bca13e9fed0ff8a213980dc0929e454b7afe73bd76e8170030deca3d04
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQJIBAABCAAyFiEEM9A2ln/PD3ETNLB5aoj0JQirT8YFAmLKjQQUHG1vcml0ekBw
b2xkcmFjay5kZXYACgkQaoj0JQirT8bUzA/+NUpiPqJyAS4NOaUu2yi4d4dRZtJ3
cvs8U+z4GJdE2+bCPRFYRxNwqt9Y4aZyC09qXeak3edj79UUi6QmrsebakenfSeT
EefQnfMVTXERIJjLr4LHl8WNQsRTkPEoCkHypFslv5GqcXx/nptIpJDCPcbMXWQz
eFMtlXuPdU3L4T+nczUJsnz4nhAzFOS1BVMo3v05haXGim0IA3iWGc1xYeZX8cst
kzIJeNfpW3gpuaV2KEzW5/t6j6gTRIcxOhiSdP63sbjrbUR35lQFgXqHEA8qyIyA
Movt6Rx//sWC/ot7fmve7IOB1RNTVOuJgsuEvalGQFvdOj/GiCK0NriMqT/4RcUH
0yRmSc0lvCTZwkgNYRl5OcuyLRwh8flAgGo9ob/0TTPpmUnjgb1DojqThP9ssGjt
TH4xADD7AMECAEsECySTwYDT2xYG35aZlfMmdXv5Nie4W57AFmxCMv6Pxr7yUtdD
qU9Ke7AJWpuf/agPl/wdEHaRUBYaBy+JYMPNQcfC1l18j34MHk3ObYSyj+QhNqt/
vRyaPfUw1NRcwR7YgoMl0id75pZHoI7DjVRJENRmnVW2khJx58KUUCfZmKz/rqDu
e7JoIiQnIk7fj46SHtDUdA/0obFWkCqm1nZDuNLfBt41yYc5Gz2tcWWkJv+eIHHC
M9ddyWfFRbjRTd8=
=ht/f
-----END PGP SIGNATURE-----

--58bca13e9fed0ff8a213980dc0929e454b7afe73bd76e8170030deca3d04--