Feedback-ID: i3ad947a1:Fastmail
Content-Type: multipart/signed;
 boundary=b71e20569b855edcae31063bd2107e9e4dea14c830ae627f4da73ad6bd2b;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Date: Sun, 10 Jul 2022 12:26:05 -0500
Message-Id: <CLC5HG2HGN45.22PPJNDTCDYNA@TimBook-Arch>
Subject: Re: [PATCH aerc] Allow not marking viewed messages as seen.
From: "Tim Culverhouse" <tim@timculverhouse.com>
To: "James Cook" <falsifian@falsifian.org>, "Moritz Poldrack"
 <moritz@poldrack.dev>, <~rjarry/aerc-devel@lists.sr.ht>
References: <20220705060618.68685-1-falsifian@falsifian.org>
 <CLAGWLDXIV6M.2KH3WJUCNXDRM@TimBook-Arch>
 <CLBLJEF0Y8M8.37UIZII0LE4TG@moth.falsifian.org>
 <CLBTUDQ29NM8.1Q41X548XI78B@Archetype>
 <CLC2LS6BW4PP.5YE3QHA8D6KD@moth.falsifian.org>
 <CLC3W7D71TSY.WLIXVX3UO4SJ@Archetype>
 <CLC4DZQ6W1XU.3UDATWOY1HO25@moth.falsifian.org>
In-Reply-To: <CLC4DZQ6W1XU.3UDATWOY1HO25@moth.falsifian.org>
Cc: 

--b71e20569b855edcae31063bd2107e9e4dea14c830ae627f4da73ad6bd2b
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Sun Jul 10, 2022 at 11:34 AM CDT, James Cook wrote:
> I can try adding the change to unset \Seen myself, but probably won't
> have time until next weekend, so if you or someone else wants to do the
> work, please go ahead. (We could also just say the setting is not
> supported with IMAP.)

First, I think we should support the feature for all workers.

Second, I really think an approach like below is best. In both cases, it's =
only
one call to the imap server and is very few lines of code to implement.

diff --git a/worker/imap/fetch.go b/worker/imap/fetch.go
index 7d7b72f..5beb886 100644
--- a/worker/imap/fetch.go
+++ b/worker/imap/fetch.go
@@ -96,6 +96,9 @@ func (imapw *IMAPWorker) handleFetchMessageBodyPart(
 		partBodySection.Specifier =3D imap.TextSpecifier
 	}
 	partBodySection.Path =3D msg.Part
+	if msg.Peek {
+		partBodySection.Peek =3D true
+	}
=20
 	items :=3D []imap.FetchItem{
 		imap.FetchEnvelope,
@@ -150,6 +153,9 @@ func (imapw *IMAPWorker) handleFetchFullMessages(
=20
 	imapw.worker.Logger.Printf("Fetching full messages")
 	section :=3D &imap.BodySectionName{}
+	if msg.Peek {
+		section.Peek =3D true
+	}
 	items :=3D []imap.FetchItem{
 		imap.FetchEnvelope,
 		imap.FetchFlags,
diff --git a/worker/types/messages.go b/worker/types/messages.go
index e303ade..67658c5 100644
--- a/worker/types/messages.go
+++ b/worker/types/messages.go
@@ -125,12 +125,14 @@ type FetchMessageHeaders struct {
 type FetchFullMessages struct {
 	Message
 	Uids []uint32
+	Peek bool
 }
=20
 type FetchMessageBodyPart struct {
 	Message
 	Uid  uint32
 	Part []int
+	Peek bool
 }
=20
 type FetchMessageFlags struct {

--b71e20569b855edcae31063bd2107e9e4dea14c830ae627f4da73ad6bd2b
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEPEbs97ymvqQFTi1YPNHFcmbSSHIFAmLLC64ACgkQPNHFcmbS
SHKvdA//QLJt2iXILAidTtF5wMC56YAwsxi3Urvfo+Pzv46L326MYp+5cRQEjM5D
BpNehtHZ2IhGjVwcWgdsaGAhuesqQ87fxutOhZUiGKNw8ROOihWx0PgvRdA14VR4
lHPMMMRRp4fL+8y6lpjExYdoxBPnJvEKBXDW59Z3eayzwW/5m75Bbjf5SrGNPDoT
Gmnc87dWP2In96PmUt463PiwPaTy1m2YW+b0X2sAy+0NUMSZj1DjOshzuXgAdZQL
9pqE7rqfcOGWaQ9qP8nA3far7CHjw2PIPX9PaZOwf5+06/AvGM9PCsFa/d39Aa9H
M1WxU2iWrepNflnk47gcygdBnfBiRqrcinuSv1by2xZmZnxxnXPiSEn5rTQxn2fR
77pv7xbKHc4taI5mLH090bu2HjWhxlnK7rvBgXgAXglCXnmMvQmqDlvRi/GYVJf3
S+lviwj72ey/0hVYW0XTDAzobjmMVl1p1oKD+CARPo9ieOKmmAigBmXG58/wBWKs
S2gXHUyQEmvUd3rMShvMndOsNiG5pPWRizin1CGFbKCS2dKQ+pmng6Cu9BcIk5BZ
T2nnUvJ68Uewm27lMCeEGZ2zzmNJU5a7bWIdCN5ikWyeb17SXBfH677LVQF4gdQR
UmWyAN/fab6H0jmQjMvFlLjKmBBtGLeT68jLiCPlscgcG3y/QC4=
=dAyk
-----END PGP SIGNATURE-----

--b71e20569b855edcae31063bd2107e9e4dea14c830ae627f4da73ad6bd2b--