Authentication-Results: mail-b.sr.ht; dkim=none Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by mail-b.sr.ht (Postfix) with ESMTPS id 2DB4F11EE5E for <~rjarry/aerc-devel@lists.sr.ht>; Sun, 10 Jul 2022 18:25:55 +0000 (UTC) Received: (Authenticated sender: robin@jarry.cc) by mail.gandi.net (Postfix) with ESMTPSA id 4D02C100002; Sun, 10 Jul 2022 18:25:53 +0000 (UTC) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 From: "Robin Jarry" To: "James Cook" , <~rjarry/aerc-devel@lists.sr.ht> X-Sourcehut-Patchset-Update: NEEDS_REVISION Subject: Re: [PATCH aerc] Allow not marking viewed messages as seen. Date: Sun, 10 Jul 2022 20:25:52 +0200 Message-Id: User-Agent: aerc/0.10.0-62-g0e889045e8b8-dirty References: <20220705060618.68685-1-falsifian@falsifian.org> In-Reply-To: <20220705060618.68685-1-falsifian@falsifian.org> Cc: James Cook, Jul 05, 2022 at 08:06: > Fixes: https://todo.sr.ht/~rjarry/aerc/48 > Signed-off-by: James Cook > --- > Sending this out for feedback. I should probably test it at least a > little more; e.g. I haven't tried deleting a message to check that the > change to delete.go makes sense. Hey James, The concept looks nice. Having the option in UI is weird but it allows contextual configuration (per-account, folder, etc.), so I guess I can live with it. I was never fond of this dependency between aerc.conf and accounts.conf. Ideally these two files should be completely independent. Any account/folder specific stuff should be in accounts.conf. Anyways, I agree with Tim about conditionally setting the Peek flag when fetching the message body in IMAP when auto-mark-read=3Dfalse. That way, no need to worry about setting or un-setting that \Seen flag. Cheers