Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 20 Aug 2022 00:31:44 +0000
Message-Id: <CMAFL4ZDR55J.17G3PA2UC6R2S@moth.falsifian.org>
Subject: Re: [PATCH aerc] Use IMAP PEEK and allow not marking messages read.
From: "James Cook" <falsifian@falsifian.org>
To: "James Cook" <falsifian@falsifian.org>, <~rjarry/aerc-devel@lists.sr.ht>
References: <CLC6R7U7HXHI.HWEUHR6XAYV5@marty>
 <20220820002218.43914-1-falsifian@falsifian.org>
In-Reply-To: <20220820002218.43914-1-falsifian@falsifian.org>

On Sat Aug 20, 2022 at 12:22 AM UTC, James Cook wrote:
> This commit adds a new configuration option, auto-mark-read, which
> defaults to true. When set to false, emails are not marked as seen when
> viewed.
>
> We also fetch BODY.PEEK[...] instead of BODY when fetching messages with
> IMAP. This means messages are only marked as read when we deliberately
> set the flag (which we automatically anyway, as long as
> auto-mark-read=3Dtrue).
>
> I imagine before this change the export-mbox command caused all messages
> in an IMAP folder to be marked as seen.
>
> Fixes: https://todo.sr.ht/~rjarry/aerc/48
> Signed-off-by: James Cook <falsifian@falsifian.org>

This patch unconditionally peeks, based on the patch Tim sent*. I chose
to make in unconditional for two reasons:

1. aerc already explicitly sets the Seen flag (now as long as
   auto-mark-read is false).

2. I started integrating Tim's suggested change which adds a "Peek"
   field to two structs, but I found it added a fair bit of plumbing,
   because it means whoever is calling the functions that generate those
   structs needs to pass an extra parameter saying whether Peek should
   be true. It felt unnecessarily complicated given that my patch is
   already separately plumbing through the auto-mark-read option.

See the comment about export-mbox in the commit message. I considered
updating the documentaton to export-mbox to explicitly say it won't
cause things to be marked as read, but it seems to me a reasonably user
would assume that behaviour anyway. (I didn't actually confirm that the
previous behaviour was to mark everything read.)

*I should have acknowledged Tim in the commit message; if you commit
this version, please add some acknowledgement like "Thanks to Tim
Culverhouse for the IMAP PEEK code" to the commit message.


--=20
James