Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 20 Aug 2022 16:21:54 +0000
Message-Id: <CMAZSN3IS514.QRSX05V6IXT8@moth.falsifian.org>
To: "Tim Culverhouse" <tim@timculverhouse.com>, "Moritz Poldrack"
 <moritz@poldrack.dev>, <~rjarry/aerc-devel@lists.sr.ht>
Subject: Re: [PATCH aerc] Use IMAP PEEK and allow not marking messages read.
From: "James Cook" <falsifian@falsifian.org>
References: <CLC6R7U7HXHI.HWEUHR6XAYV5@marty>
 <20220820002218.43914-1-falsifian@falsifian.org>
 <CMAOGU0XV5HK.AVX8CZ2GH384@Archetype>
 <CMAX3QJA8ATV.1NSRFYM2OEALH@moth.falsifian.org>
 <CMAXRYNX38L8.33IA8OO53PC7U@TimBook-Arch>
In-Reply-To: <CMAXRYNX38L8.33IA8OO53PC7U@TimBook-Arch>

> 1. Move store.Flag to worker because it's currently redundant for IMAP,
> but needed for other workers
>
> 2. Add PEEK option to the worker message and all relevant function
> calls, with the fix to the ones that should be true
>
> 3. Add the option to set peek on opening message
>
> This approach, at least to me, makes the imap worker more efficient than
> it currently is, fixes some bugs, and gets this feature in.
>
> Tim

I like this plan, except I wonder if #1 and #2 should be done in the
same patch. If I understand you right, after #1, every message fetch
would cause it to be marked as read, including e.g. running :pipe, so
non-IMAP backends would get a little bit broken until step #2 is
implemented.

--=20
James