Content-Type: multipart/signed;
 boundary=d2da7caf9c2e295c69d4e52f6b54a7d28f906764f2882b2897bbfec32a8f;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Subject: Re: [PATCH aerc] Use IMAP PEEK and allow not marking messages read.
From: "Moritz Poldrack" <moritz@poldrack.dev>
To: "James Cook" <falsifian@falsifian.org>, "Tim Culverhouse"
 <tim@timculverhouse.com>, <~rjarry/aerc-devel@lists.sr.ht>
Date: Sat, 20 Aug 2022 20:44:19 +0200
Message-Id: <CMB2TOHJV37C.1OV8OOXSWQB5N@Archetype>
References: <CLC6R7U7HXHI.HWEUHR6XAYV5@marty>
 <20220820002218.43914-1-falsifian@falsifian.org>
 <CMAOGU0XV5HK.AVX8CZ2GH384@Archetype>
 <CMAX3QJA8ATV.1NSRFYM2OEALH@moth.falsifian.org>
 <CMAXRYNX38L8.33IA8OO53PC7U@TimBook-Arch>
 <CMAZSN3IS514.QRSX05V6IXT8@moth.falsifian.org>
In-Reply-To: <CMAZSN3IS514.QRSX05V6IXT8@moth.falsifian.org>

--d2da7caf9c2e295c69d4e52f6b54a7d28f906764f2882b2897bbfec32a8f
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Sat Aug 20, 2022 at 6:21 PM CEST, James Cook wrote:
> > 1. Move store.Flag to worker because it's currently redundant for IMAP,
> > but needed for other workers
> >
> > 2. Add PEEK option to the worker message and all relevant function
> > calls, with the fix to the ones that should be true
> >
> > 3. Add the option to set peek on opening message
> >
> > This approach, at least to me, makes the imap worker more efficient tha=
n
> > it currently is, fixes some bugs, and gets this feature in.
> >
> > Tim
>
> I like this plan, except I wonder if #1 and #2 should be done in the
> same patch.
I don't think that merging them makes a lot of sense=E2=80=A6 I think their
topics are different enough to warrant multiple commits.

> If I understand you right, after #1, every message fetch would cause
> it to be marked as read, including e.g. running :pipe, so non-IMAP
> backends would get a little bit broken until step #2 is implemented.
Not necessarily. While extracting you can already add a way to pass
whether to mark as read or not. Otherwise I don't think it matters if
one patch in between changes the default behaviour slightly when the
next commit already restores said standard.

--d2da7caf9c2e295c69d4e52f6b54a7d28f906764f2882b2897bbfec32a8f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJIBAABCAAyFiEEM9A2ln/PD3ETNLB5aoj0JQirT8YFAmMBLGYUHG1vcml0ekBw
b2xkcmFjay5kZXYACgkQaoj0JQirT8ZaQQ//S7fy0AcCsQNO1+HfPE/4+eqF6WoL
1zssKTGe9515oc8Jt1DNaUkQdW45PgfMBFrC9prZTNtvBSMYVb6ieGveXQrjnmrq
vujoexTG1Dx/1OnO64nFGGskvR+Io2FgmatoyPwy48+U2nCjhOMa7MTTRT9Z3kMd
+Ax83XxneLSeOA1uLgWdar4G4zqnvtdtlp0Z7XVFVCr0QEZjYXuwDqblfB9/YovW
CKmYFbLI21LP60hPZqDR44dgC9ttFzTECYRnBMcwoX5FAvpV9JnOHd0idsuAqeX9
WlRpzt4y4pJjOKPIte4HJo5b2pjI+giEYpEAhnlF45wr5BKiyKRLQtOCka+n5qpx
Py2aoC1U99wLmrMGQmvbg7OS0Imnjz82KmzRGhdCSFzzlZZjTTd+cegk/HFN9BO/
KFhOB6XXkHbeQjt6/UC5jCqaH/Gq+Z8WPK4tbsxI9lXGLZO4keY6AjWfS9dOePbr
E6oDxrBGVaKTjBonCn4hkedJPdKQf/c/IaMC61IZ4G7bbpeGzXIqa66ZtSSDed67
F/BE8LoR0UB46ccnrj4LngPDE3QI949PiAsm2NsKjluSshgs9sT1YH6o0xezqjb8
lxouhSt5BsBAHv1uNWmsLyWj+zI0Ll8qo8rNzyfwutmwsxT9pHIBP8lq/6a+0PEA
h27lSuUX2V8sA6o=
=EFlj
-----END PGP SIGNATURE-----

--d2da7caf9c2e295c69d4e52f6b54a7d28f906764f2882b2897bbfec32a8f--