Feedback-ID: i3ad947a1:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 20 Aug 2022 14:02:30 -0500
Message-Id: <CMB37LW8ACBY.16SJEJRIROCZH@TimBook-Arch>
Subject: Re: [PATCH aerc] Use IMAP PEEK and allow not marking messages read.
From: "Tim Culverhouse" <tim@timculverhouse.com>
To: "Moritz Poldrack" <moritz@poldrack.dev>, "James Cook"
 <falsifian@falsifian.org>, <~rjarry/aerc-devel@lists.sr.ht>
References: <CLC6R7U7HXHI.HWEUHR6XAYV5@marty>
 <20220820002218.43914-1-falsifian@falsifian.org>
 <CMAOGU0XV5HK.AVX8CZ2GH384@Archetype>
 <CMAX3QJA8ATV.1NSRFYM2OEALH@moth.falsifian.org>
 <CMAXRYNX38L8.33IA8OO53PC7U@TimBook-Arch>
 <CMAZSN3IS514.QRSX05V6IXT8@moth.falsifian.org>
 <CMB2TOHJV37C.1OV8OOXSWQB5N@Archetype>
In-Reply-To: <CMB2TOHJV37C.1OV8OOXSWQB5N@Archetype>

On Sat Aug 20, 2022 at 1:44 PM CDT, Moritz Poldrack wrote:
> > I like this plan, except I wonder if #1 and #2 should be done in the
> > same patch.
> I don't think that merging them makes a lot of sense=E2=80=A6 I think the=
ir
> topics are different enough to warrant multiple commits.

I think it makes sense to combine...Not combining breaks between
commits, while combining implements the fix.

1. Move store.Flag to workers, and make it so that everything that
*shouldn't* mark as read, does so. Behavior the same for
maildir/notmuch/mbox, and a fix for imap.

2. Add config option to leave message unread when opening. Works the
same for all backends.