aerc: Build on OpenBSD and also test make install v1 SUPERSEDED

Mark Dain: 1
 Build on OpenBSD and also test make install

 5 files changed, 22 insertions(+), 13 deletions(-)

[PATCH aerc] Build on OpenBSD and also test make install Export this patch

This commit drops Arch Linux in favor of a BSD so there's more variety
in CI.

See: https://lists.sr.ht/~rjarry/aerc-devel/%3C20220122033806.91728-1-ktprograms%40gmail.com%3E

Robin Jarry <robin@jarry.cc>

3 months ago

I wanted to do this but I was limited to 4 builds. I guess dropping Arch
is OK. Too bad we cannot test on macOS. I'll think about adding CI on
the github mirror.

Next

Additionally, `make install' is now covered by the tests.

Robin Jarry <robin@jarry.cc>

3 months ago

Please move this make install thing in a separate patch.

Next

---
 .builds/alpine-edge.yml   |  2 ++
 .builds/archlinux.yml     | 13 -------------
 .builds/debian-stable.yml |  2 ++
 .builds/fedora-latest.yml |  2 ++
 .builds/openbsd.yml       | 16 ++++++++++++++++
 5 files changed, 22 insertions(+), 13 deletions(-)
 delete mode 100644 .builds/archlinux.yml
 create mode 100644 .builds/openbsd.yml

diff --git a/.builds/alpine-edge.yml b/.builds/alpine-edge.yml
index fa9a49f..7118bac 100644
--- a/.builds/alpine-edge.yml
+++ b/.builds/alpine-edge.yml
@@ -11,6 +11,8 @@ tasks:
 - build: |
     cd aerc
     make
+    mkdir out

Robin Jarry <robin@jarry.cc>

3 months ago

This is not required. make install should create missing dirs.

Next

+    make DESTDIR=./out install

Robin Jarry <robin@jarry.cc>

3 months ago

Can you put this into a separate "install" step?

I wonder if you could also verify if the installation looks OK. To avoid
code duplication, this could be a `make checkinstall` target. Ideally
introduced in a third patch ;)

 - test: |
     cd aerc
     go test ./...
diff --git a/.builds/archlinux.yml b/.builds/archlinux.yml
deleted file mode 100644
index f5c74ac..0000000
--- a/.builds/archlinux.yml
@@ -1,13 +0,0 @@
-image: archlinux
-packages:
-- go
-- scdoc
-sources:
-- https://git.sr.ht/~rjarry/aerc
-tasks:
-- build: |
-    cd aerc
-    make
-- test: |
-    cd aerc
-    go test ./...
diff --git a/.builds/debian-stable.yml b/.builds/debian-stable.yml
index 5a406c8..11cf5c6 100644
--- a/.builds/debian-stable.yml
+++ b/.builds/debian-stable.yml
@@ -8,6 +8,8 @@ tasks:
 - build: |
     cd aerc
     make
+    mkdir out
+    make DESTDIR=./out install
 - test: |
     cd aerc
     go test ./...
diff --git a/.builds/fedora-latest.yml b/.builds/fedora-latest.yml
index 997daff..e80d070 100644
--- a/.builds/fedora-latest.yml
+++ b/.builds/fedora-latest.yml
@@ -8,6 +8,8 @@ tasks:
 - build: |
     cd aerc
     make
+    mkdir out
+    make DESTDIR=./out install
 - test: |
     cd aerc
     go test ./...
diff --git a/.builds/openbsd.yml b/.builds/openbsd.yml
new file mode 100644
index 0000000..46cc5f7
--- /dev/null
+++ b/.builds/openbsd.yml
@@ -0,0 +1,16 @@
+---
+image: openbsd/latest
+packages:
+  - go
+  - scdoc
+sources:
+  - https://git.sr.ht/~rjarry/aerc
+tasks:
+  - build: |
+        cd aerc
+        make
+        mkdir out
+        make DESTDIR=./out install
+  - test: |
+        cd aerc
+        go test ./...
--
2.34.1

builds.sr.ht <builds@sr.ht>

3 months ago

aerc/patches: SUCCESS in 4m0s

[Build on OpenBSD and also test make install][0] from [Mark Dain][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/28619
[1]: mailto:mark@markdain.net

✓ #677817 SUCCESS aerc/patches/alpine-edge.yml   https://builds.sr.ht/~rjarry/job/677817
✓ #677819 SUCCESS aerc/patches/debian-stable.yml https://builds.sr.ht/~rjarry/job/677819
✓ #677818 SUCCESS aerc/patches/archlinux.yml     https://builds.sr.ht/~rjarry/job/677818
✓ #677820 SUCCESS aerc/patches/fedora-latest.yml https://builds.sr.ht/~rjarry/job/677820

Robin Jarry <robin@jarry.cc>

3 months ago

Mark Dain, Jan 22, 2022 at 10:58: