aerc: reload: reload everything if no flags are provided v1 APPLIED

Jason Cox: 1
 reload: reload everything if no flags are provided

 2 files changed, 9 insertions(+), 0 deletions(-)

[PATCH aerc] reload: reload everything if no flags are provided Export this patch

Currently, the :reload command silently does nothing if no flags are
provided. Eliminate this confusion by reloading all reloadable configs
in the absence of flags.

Signed-off-by: Jason Cox <me@jasoncarloscox.com>
---

Robin Jarry <robin@jarry.cc>

a month ago

Acked-by: Robin Jarry <robin@jarry.cc>

Applied, thanks.

To git@git.sr.ht:~rjarry/aerc
   4e950b989e30..2950d919a5c5  master -> master

 commands/reload.go | 6 ++++++
 doc/aerc.1.scd     | 3 +++
 2 files changed, 9 insertions(+)

Koni Marti <koni.marti@gmail.com>

a month ago

Thanks! Makes sense and looks good.

Reviewed-by: Koni Marti <koni.marti@gmail.com>

diff --git a/commands/reload.go b/commands/reload.go
index cd32bb36..2888ef90 100644
--- a/commands/reload.go
+++ b/commands/reload.go
@@ -47,6 +47,12 @@ func (Reload) Aliases() []string {
 }
 
 func (r Reload) Execute(args []string) error {
+	if !r.Binds && !r.Conf && r.Style == "" {
+		r.Binds = true
+		r.Conf = true
+		r.Style = config.Ui.StyleSetName
+	}
+
 	reconfigure := false
 
 	if r.Binds {
diff --git a/doc/aerc.1.scd b/doc/aerc.1.scd
index d178eb5f..9d1d3302 100644
--- a/doc/aerc.1.scd
+++ b/doc/aerc.1.scd
@@ -274,6 +274,9 @@ These commands work in any context.
 	Hot-reloads the config files for the key binds and general *aerc* config.
 	Reloading of the account config file is not supported.
 
+	If no flags are provided, _binds.conf_, _aerc.conf_, and the current
+	styleset will all be reloaded.
+
 	*-B*: Reload _binds.conf_.
 
 	*-C*: Reload _aerc.conf_.
-- 
2.46.0

builds.sr.ht <builds@sr.ht>

a month ago

aerc/patches: SUCCESS in 1m59s

[reload: reload everything if no flags are provided][0] from [Jason Cox][1]

[0]: https://lists.sr.ht/~rjarry/aerc-devel/patches/54656
[1]: mailto:me@jasoncarloscox.com

✓ #1309925 SUCCESS aerc/patches/openbsd.yml     https://builds.sr.ht/~rjarry/job/1309925
✓ #1309924 SUCCESS aerc/patches/alpine-edge.yml https://builds.sr.ht/~rjarry/job/1309924

Robin Jarry <robin@jarry.cc>

a month ago

Jason Cox <me@jasoncarloscox.com> wrote: