From Rajiv Kanchan to ~eliasnaur/gio-patches
pointer.Cancel event is ignored, resulting in Hovered returning true even though the pointer is no longer hovering over the region. This change fixes it. Signed-off-by: Rajiv Kanchan <rajiivkanchan@gmail.com> --- gesture/gesture.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gesture/gesture.go b/gesture/gesture.go index 2d63963c..33201f70 100644 --- a/gesture/gesture.go +++ b/gesture/gesture.go @@ -51,7 +51,7 @@ func (h *Hover) Hovered(q event.Queue) bool { [message trimmed]
From Rajiv Kanchan to ~eliasnaur/gio
While dragging a widget using gesture.Drag, which is also listening to gesture.Hover events, the Hover handler loses out to the Drag handler and receives a pointer.Cancel, but "func (h *Hover) Hovered(q event.Queue) bool" continues to return true. Unless I am using this incorrectly, in which case please educate me, I believe that the pointer.Cancel event should be considered to have a similar effect as that of pointer.Leave making "func (h *Hover) Hovered(q event.Queue) bool" return false. See reproducer code below along with a screencast. Reproducer Code: https://paste.sr.ht/~rkanchan/9135fa0ccb5cc89383559cdad3a23deac6594849
From Rajiv Kanchan to ~sircmpwn/email-test-drive
Testing plain text
From Rajiv Kanchan to ~sircmpwn/email-test-drive
Testing plaintext
From Rajiv Kanchan to ~sircmpwn/email-test-drive
--- This fixes the issues raised from the first patch. Rajiv-Kanchan | 1 + 1 file changed, 1 insertion(+) create mode 100644 Rajiv-Kanchan diff --git a/Rajiv-Kanchan b/Rajiv-Kanchan new file mode 100644 index 0000000..66cb3d4 --- /dev/null +++ b/Rajiv-Kanchan @@ -0,0 +1 @@ I have successfully used git send-email! [message trimmed]
From Rajiv Kanchan to ~sircmpwn/email-test-drive
--- Rajiv-Kanchan | 1 + 1 file changed, 1 insertion(+) create mode 100644 Rajiv-Kanchan diff --git a/Rajiv-Kanchan b/Rajiv-Kanchan new file mode 100644 index 0000000..6d0ecfd --- /dev/null +++ b/Rajiv-Kanchan @@ -0,0 +1 @@ I'm about to try git send-email -- 2.25.1 [message trimmed]
From Rajiv Kanchan to ~eliasnaur/gio
Compiling with the latest version of Gio, I get the following error. What dependencies need to be installed on Ubuntu to get Vulkan working? # gioui.org/internal/vk ../../go/pkg/mod/gioui.org@v0.0.0-20210922165522-6665e0ef0fe6/internal/vk/vulkan.go:15:10: fatal error: vulkan/vulkan.h: No such file or directory 15 | #include <vulkan/vulkan.h> | ^~~~~~~~~~~~~~~~~ compilation terminated. -- Rajiv
From Rajiv Kanchan to ~eliasnaur/gio-patches
Edit events were being sent twice, once upon key press and again on key release for special keys such as Enter, Arrow keys etc, which resulted in duplicate inputs while pressing these keys. key.EditEvents for special keys now fire once on key press only. Signed-off-by: Rajiv Kanchan <rajiivkanchan@gmail.com> --- app/internal/xkb/xkb_unix.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/internal/xkb/xkb_unix.go b/app/internal/xkb/xkb_unix.go index 2f0fefa..680df6b 100644 --- a/app/internal/xkb/xkb_unix.go +++ b/app/internal/xkb/xkb_unix.go @@ -170,7 +170,9 @@ func (x *Context) DispatchKey(keyCode uint32, state key.State) (events []event.E if sym == C.XKB_KEY_ISO_Left_Tab { cmd.Modifiers |= key.ModShift [message trimmed]
From Rajiv Kanchan to ~eliasnaur/gio
All of the widgets in package material follow an API naming convention similar to the Editor widget below (Removed params for brevity) func Editor() EditorStyle My question is, why not follow the Go convention and use the "New" prefix for the constructor and drop the "Style" suffix for the widget types. Like func NewEditor() Editor -Rajiv
From Rajiv Kanchan to ~eliasnaur/gio
I take that back. I do see a delay on GTK apps as well. For some reason it wasn't apparent when I first tried. Apologies.