On Wed Sep 20, 2023 at 2:02 AM CDT, inwit wrote:
> On 19/09/2023, 23:19, Robin Jarry wrote:
> > How about "show-thread-context" instead to match the style object name (see
> > below)?
> Wouldn't it be better "show-message-context"? Since the command really applies
> to messages and not threads and given that, in notmuch, a thread is an
> auto-contained object, "thread-context" sounds a bit weird to me.

I prefer show-thread-context, this view only exists in a threaded view...this
is also more closely aligned to notmuch terminology ("show-entire-thread").

> Also, currently the command applies to all the listed messages in current
> folder/query: either we use "show-messages-context", in plural, or we change
> the behaviour of the command to apply to just the selected message. The later

Remove the previous split from the account grid view. When adding a new
child at an existing location, the content is appended to a slice
instead of replacing any old values. The old content must be explicitly
removed.

Reported-by: inwit <inwit@sindominio.net>
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 widgets/account.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/widgets/account.go b/widgets/account.go
index b5c71c297e73..7c4a5e17d4df 100644
--- a/widgets/account.go
[message trimmed]

Add a command to toggle the display of an entire-thread. Update
CHANGELOG

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 CHANGELOG.md                         |  1 +
 commands/msg/toggle-entire-thread.go | 36 ++++++++++++++++++++++++++++
 doc/aerc.1.scd                       |  4 ++++
 lib/msgstore.go                      |  8 +++++++
 4 files changed, 49 insertions(+)
 create mode 100644 commands/msg/toggle-entire-thread.go

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 20a1697fbe66..5d2cbba7eeef 100644
[message trimmed]

Add a UI config value to enable showing of an "entire thread", similar
to `notmuch show --entire-thread=true`. Add an associated style called
"msglist_borrowed" which can be used to style such messages.

Currently this feature is only supported by notmuch. It would be
possible for maildir to implement as well, IMAP with gmail custom
extensions, and JMAP. This patch merely implements the notmuch version
and puts the groundwork in for handling these sorts of displays.

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 commands/commands_test.go      |  1 +
 config/aerc.conf               |  8 ++++++++
 config/style.go                |  2 ++
[message trimmed]

On Wed Sep 6, 2023 at 1:53 PM CDT, Vitaly Ovchinnikov wrote:
> Add the logging of stdout/stderr of mail checking process in maildir
> worker if it returns an error.
>
> The user still sees just the exit status, but log gets a more detailed
> information for further analysis.
>
> Signed-off-by: Vitaly Ovchinnikov <v@postbox.nz>
> ---

Reviewed-by: Tim Culverhouse <tim@timculverhouse.com>

On Wed Sep 6, 2023 at 1:33 PM CDT, Vitaly Ovchinnikov wrote:
> Add the logging of stdout/stderr of mail checking process in maildir
> worker if it returns an error.
>
> The user still sees just the exit status, but log gets a more detailed
> information for further analysis.
>
> Signed-off-by: Vitaly Ovchinnikov <v@postbox.nz>
> ---

I guess I was too quick on the review. The linter wants you to use errors.As
instead of a type assertion. After that though I think we are good!

--

On Wed Sep 6, 2023 at 1:33 PM CDT, Vitaly Ovchinnikov wrote:
> Add the logging of stdout/stderr of mail checking process in maildir
> worker if it returns an error.
>
> The user still sees just the exit status, but log gets a more detailed
> information for further analysis.
>
> Signed-off-by: Vitaly Ovchinnikov <v@postbox.nz>
> ---

Reviewed-by: Tim Culverhouse <tim@timculverhouse.com>

The LimitHeaders function is used to optionally reduce memory usage of
aerc by only keeping certain headers in memory for the message list. The
function properly deletes header keys and values from the underlying
object, however the underlying data structure has a map and a slice -
which do not get resized after deletion: resulting in no actual memory
savings.

Create a new header and add only the headers we want to it. Return this
value and use in the MessageInfo struct.

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
v2: simplify logic (thanks Moritz!)
[message trimmed]

On Tue Sep 5, 2023 at 12:01 AM CDT, Moritz Poldrack wrote:
> On Mon Sep 4, 2023 at 5:57 PM CEST, Tim Culverhouse wrote:
> > diff --git a/worker/lib/parse.go b/worker/lib/parse.go
> > index 2baf13f7dbc2..808fb6d73794 100644
> > --- a/worker/lib/parse.go
> > +++ b/worker/lib/parse.go
> > @@ -312,26 +312,28 @@ func MessageInfo(raw RawMessage) (*models.MessageInfo, error) {
> >  
> >  // LimitHeaders returns a new Header with the specified headers included or
> >  // excluded
> > -func LimitHeaders(hdr *mail.Header, fields []string, exclude bool) {
> > +func LimitHeaders(hdr *mail.Header, fields []string, exclude bool) *mail.Header {
> >  	fieldMap := make(map[string]struct{}, len(fields))
> >  	for _, f := range fields {

The LimitHeaders function is used to optionally reduce memory usage of
aerc by only keeping certain headers in memory for the message list. The
function properly deletes header keys and values from the underlying
object, however the underlying data structure has a map and a slice -
which do not get resized after deletion: resulting in no actual memory
savings.

Create a new header and add only the headers we want to it. Return this
value and use in the MessageInfo struct.

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 worker/lib/parse.go      | 14 ++++++++------
 worker/maildir/worker.go |  4 ++--
[message trimmed]