~rockorager

St. Paul, MN

https://www.timculverhouse.com/

~rockorager/public-inbox

Last active a month ago
View more

Recent activity

Re: [PATCH aerc] gpg: fix error handling during decryption 5 hours ago

From Tim Culverhouse to ~rjarry/aerc-devel

I resubmitted with the updated build manifest and it passes:

https://builds.sr.ht/~rockorager/job/789699

[PATCH aerc] gpg: fix error handling during decryption a day ago

From Tim Culverhouse to ~rjarry/aerc-devel

An non-zero exit code from the execution of gpg during decryption would
prevent aerc from parsing the output of gpg. The output should always be
parsed. Gpg can exit with an error due to not being able to validate a
signature. Aerc handles this error with the UI, and therefore all output
should be parsed regardless of exit state of gpg. The parsing of stdout
will find the errors and report back to aerc properly.

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 lib/crypto/gpg/gpgbin/decrypt.go | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/crypto/gpg/gpgbin/decrypt.go b/lib/crypto/gpg/gpgbin/decrypt.go
index fd11b75..0962630 100644
[message trimmed]

Re: Unsupported micalg 2 days ago

From Tim Culverhouse to ~rjarry/aerc-discuss

Sorry for the repeated replies, everyone!

I just submitted the PR to emersion/go-pgpmail for converting the raw
micalg to lowercase.

https://github.com/emersion/go-pgpmail/pull/13

Re: Unsupported micalg 2 days ago

From Tim Culverhouse to ~rjarry/aerc-discuss

On Sun Jun 26, 2022 at 12:16 PM CDT, Tim Culverhouse wrote:
> On Sun Jun 26, 2022 at 11:57 AM CDT, Kenneth Flak wrote:
> > Hi list,
> >
> > I am getting quite a few "unsupported micalg: SHA256" these days,
> > including from people on this very list. The only way to access the
> > email in aerc is by hitting :rq, which still lets me see the email text
> > as a quoted reply. I've seen quite a bit of activity lately on pgp in
> > the devel-list lately, though, so maybe a fix is in the works? Or is
> > there some other way to get SHA256 to work?

I looked a little deeper. I'm not sure how we want to support this one,
actually. We have to reach outside of the specification for PGP-MIME.
The spec [1] says the micalg must be of the form

Re: Unsupported micalg 2 days ago

From Tim Culverhouse to ~rjarry/aerc-discuss

On Sun Jun 26, 2022 at 11:57 AM CDT, Kenneth Flak wrote:
> Hi list,
>
> I am getting quite a few "unsupported micalg: SHA256" these days,
> including from people on this very list. The only way to access the
> email in aerc is by hitting :rq, which still lets me see the email text
> as a quoted reply. I've seen quite a bit of activity lately on pgp in
> the devel-list lately, though, so maybe a fix is in the works? Or is
> there some other way to get SHA256 to work?

Hi Ken -

Are you using GPG or the built-in PGP provider? I suspect the built-in
version but want to be sure. The GPG implementation does a

Re: [RFC] Threading 2 days ago

From Tim Culverhouse to ~rjarry/aerc-devel

On Sat Jun 25, 2022 at 2:17 PM CDT, Koni Marti wrote:
> Thanks for bringing this issue up again. It was a topic way back after
> client-side threading was introduced (on eithe IRC or mail, can't
> remember) but I never finished a patch set for this. 

Good to have some history! Must have been before I was subscribed.

> I believe that server-side threading has not been completely implemented
> in aerc yet, that's why these functions are not well supported. The
> go-imap package should provide all the functionality to have proper
> server-side sorting/search/filtering (with some modifications in the
> message store needed). This might be something we can work out after
> properly separating server and client side threading.

Re: [PATCH aerc v2 2/2] mk: fix minor issue in makefile 3 days ago

From Tim Culverhouse to ~rjarry/aerc-devel

Reviewed both in series.

Reviewed-by: Tim Culverhouse <tim@timculverhouse.com>

[PATCH aerc] gpg: don't send messages that failed encryption 3 days ago

From Tim Culverhouse to ~rjarry/aerc-devel

Add error handling for messages that were unable to be encrypted.
Previously, messages that failed encryption would be sent with no
content. This patch adds error handling - when encryption fails, the
user is returned to the Review screen and instructed to check the public
keys for their recipients.

Reported-by: Moritz Poldrack <moritz@poldrack.dev>
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 lib/crypto/gpg/gpgbin/encrypt.go | 6 +++++-
 lib/crypto/gpg/gpgbin/gpgbin.go  | 2 ++
 widgets/compose.go               | 5 ++++-
 3 files changed, 11 insertions(+), 2 deletions(-)
[message trimmed]

[PATCH aerc] open: fix mimetype discovery for encrypted or signed messages 3 days ago

From Tim Culverhouse to ~rjarry/aerc-devel

Mimetype discovery for the :open command is based on the BodyStructure
of the message. This patch fixes the method which got the BodyStructure
of the message to a more generalized one, which is set post-encryption
and post-validation. This allows encrypted or signed message parts to
have their proper mimetype discovered.

Fixes: https://todo.sr.ht/~rjarry/aerc/50
Reported-by: ~ph14nix
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
---
 commands/msgview/open.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/msgview/open.go b/commands/msgview/open.go
[message trimmed]

Re: Desktop file for linux/firefox 3 days ago

From Tim Culverhouse to ~rjarry/aerc-discuss

On Sat, Jun 25, 2022, at 2:34 AM, Kenneth Flak wrote:
> Not working for some reason, unfortunately. It turns out the call
> to kitty is redirected to xfce4-terminal, so this is what opens up
> instead. After removing xfce4-terminal from my system I am not able to
> open mailto-links at all. The aerc socket is, indeed, in the location
> you mention. Could I ask which terminal you are using, and what is the
> content of your [Default Applications] list in ~/.config/mimeapps.list?

What distribution are you using? Also which desktop environment/window manager?