~rumpelsepp

Bavaria

https://rumpelsepp.org

I break stuff.

Recent activity

Re: [PATCH 3/3] bin: list: First version of project tree printing 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

On Thu, Mar 11, 2021 at 10:26:03PM +0100, Philipp Stanner wrote:
> Working, but incomplete first draft of proj-tree printing.

Yeah, I would say, merge it soon and let's play around with it.

> ---
> Thanks for your last patch.
> I have fixed the global variable and use defer instead.
> As for the recursion: Lots of work, we'll keep it, but feel free to
> offer a patch adjusting everything in a way you viel as appropriate, and
> we can have a discussion about this.
> But this code will probably change very quickly anyways.
>  bin/qm-list/main.go | 116 ++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 100 insertions(+), 16 deletions(-)

Re: [PATCH 2/3] lib: implement search methods and project creation 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

A few nits. Rest seems ok for my first review like this in mutt.

On Thu, Mar 11, 2021 at 10:26:01PM +0100, Philipp Stanner wrote:
> Implements:
> - Projects are now created on collections.
> - Layer-Search-Methods for tree-printing of projects
> - UUIDs for projects
> ---
> Those are major changes. We will have to find a way to use Container for
> all of this soonish.
> 
>  lib/collection.go | 85 +++++++++++++++++++++++++++++++++++++++++++----
>  lib/container.go  | 20 +++++------
>  lib/project.go    |  5 ++-

Re: [PATCH 1/3] qm: improve user informing 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

IMO this makes kind of sense. In the long run I would prefer a `qm init`
command for this. Then the user has full control and `qm` does not do
any magic without being asked.

For now it is fine for me, just quickfix the typo below. :)

PS: Sent by mutt.

On Thu, Mar 11, 2021 at 10:25:59PM +0100, Philipp Stanner wrote:
> ---
>  qm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qm b/qm

[PATCH 1/3] Add a GOVERNANCE file to state the presence of a BDFL 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

---

I am a goofy and I upgraded you to the BDFL of the i3 window manager. :D

 GOVERNANCE.md | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 GOVERNANCE.md

diff --git a/GOVERNANCE.md b/GOVERNANCE.md
new file mode 100644
index 0000000..e8598dd
--- /dev/null
+++ b/GOVERNANCE.md
@@ -0,0 +1,26 @@
[message trimmed]

[PATCH 3/3] Add a STYLE document for coding hints 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

This i a Work in Progress (WIP).
---
 STYLE.md | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 STYLE.md

diff --git a/STYLE.md b/STYLE.md
new file mode 100644
index 0000000..d2748c7
--- /dev/null
+++ b/STYLE.md
@@ -0,0 +1,16 @@
# Code Style

[message trimmed]

[PATCH 2/3] Add a CONTRIBUTING file to document the patch flow 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

This is a Work in Progress (WIP).
---
 CONTRIBUTING.md | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 CONTRIBUTING.md

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..9bc4590
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,3 @@
# Contributing

[message trimmed]

[PATCH 1/3] Add a GOVERNANCE file to state the presence of a BDFL 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

---
 GOVERNANCE.md | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 GOVERNANCE.md

diff --git a/GOVERNANCE.md b/GOVERNANCE.md
new file mode 100644
index 0000000..fb10c30
--- /dev/null
+++ b/GOVERNANCE.md
@@ -0,0 +1,26 @@
# quartiermeister project governance

## Overview
[message trimmed]

Re: [PATCH] all: Implement working hierarchical subproj print 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

On Mon, 2021-03-08 at 08:23 +0100, Stefan Tatschner wrote:
> Also, don't use recursion. Every recursive code can be written in an 
> iterative way

Just saw the comment, that a better idea is welcome.

Suggestion: Create separate commits now and leave the recursion stuff
as is. We will nuke recursion in a later step once this functionality
has settled in master.

S

Re: [PATCH] all: Implement working hierarchical subproj print 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

Can you create separate, smaller commits? This is difficult to review. 
Also, I am not happy with the variable names here as there are too much 
unclear suffixes and prefixes for me. Just spend a few more letters.

On 07.03.21 23:09, Philipp Stanner wrote:
> Suproject printing now works.
> New problem: container & project are interwined too strongly.
> Should be fixed soonish.
> ---
>   bin/qm-list/main.go | 116 ++++++++++++++++++++++++++++++++++++++------
>   lib/collection.go   |  85 +++++++++++++++++++++++++++++---
>   lib/container.go    |  20 ++++----
>   lib/project.go      |   5 +-
>   qm                  |   3 +-

[PATCH 3/3] qm-create: Unify error handling 7 months ago

From Stefan Tatschner to ~imperator/quartiermeister-devel

---
 bin/qm-create/main.go | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/bin/qm-create/main.go b/bin/qm-create/main.go
index 073e74e..6bd02e2 100644
--- a/bin/qm-create/main.go
@@ -14,13 +14,12 @@ type options struct {
	parent       string
}

func createItem(c *qm.Collection, opts *options) {
func createItem(c *qm.Collection, opts *options) error {
[message trimmed]