Thanks for the patch!

If you create the patch with git you should check your config. The patch
did not include an identity, aka email/name. In the future see if you
can get a git patch through because I want you to get credit for your
commits.

--
Sam H Smith

On Sun, 2021-05-09 at 20:48 +0000, Sam H Smith wrote:
> Thanks for the patch!
> 
> If you create the patch with git you should check your config. The
> patch
> did not include an identity, aka email/name. In the future see if you
> can get a git patch through because I want you to get credit for your
> commits.
I used "git send-email --to="~samhsmith/astraos-devel@lists.sr.ht"
HEAD^" to generate the patch and send the email, which is what
https://git-send-email.io recommends/. I think it does include an
identity, but the identity is sent as the headers. I have previously
sent patches to Guix in a similar way, and they produced a similar
output. If you are applying the patch by copying/pasting the email, you
should include the headers, or do:

curl -s https://lists.sr.ht/~samhsmith/astraos-devel/patches/22625/mbox
| git am -3

as https://lists.sr.ht/~samhsmith/astraos-devel/patches/22625 suggests.
> 
> --
> Sam H Smith

-- 
Ron

I piped it straight into git am.
What does git config -l report while inside the repo?
Are user.email and user.name defined properly?
--
Sam H Smith

On Sun, 2021-05-09 at 21:14 +0000, Sam H Smith wrote:
> I piped it straight into git am.
Did what you piped into git am include the headers, or was it just the
body?
> What does git config -l report while inside the repo?
user.name=Ron Nazarov
user.email=noisytoot@disroot.org
user.signingkey=61C528F61F2CFADA9526A45B1D43EF4F4492268B
sendemail.smtpencryption=tls
sendemail.smtpserver=disroot.org
sendemail.smtpserverport=587
sendemail.smtpuser=noisytoot@disroot.org
core.excludesfile=/home/ron/.gitignore_global
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
submodule.qemu.active=true
submodule.qemu.url=https://github.com/SamHSmith/qemu.git
remote.origin.url=https://git.sr.ht/~samhsmith/AstraOS
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
> Are user.email and user.name defined properly?
Yes
-- 
Ron

> Did what you piped into git am include the headers, or was it just the
> body?
I used the pipe function in my email client aerc. I ran :pipe git am, here's it's description.
       pipe [-bmp] <cmd>
           Downloads and pipes the selected message into the given shell command, and opens a new terminal tab to show the result. By default, the selected
           message part is used in the message viewer and the full message is used in the message list.

           -b: Run the command in the background instead of opening a terminal tab

           -m: Pipe the full message

           -p: Pipe just the selected message part, if applicable

> > Are user.email and user.name defined properly?
> Yes
Could you send me another patch so I can try some different options?
--
Sam H Smith

On Mon, 2021-05-10 at 17:27 +0000, Sam H Smith wrote:
> 
> Could you send me another patch so I can try some different options?
https://lists.sr.ht/~samhsmith/astraos-devel/patches/22639

Drew DeVault uses ":pipe -mb git am -3":
https://drewdevault.com/2020/04/20/Configuring-aerc-for-git.html
-- 
Ron

Fantastic!
I got it working now. Many thanks.
Feel free to keep sending patches. And don't
hesitate to ask me if anything about the code is
unclear.
--
Sam H Smith