hi,

I've kept the original implementation of dashed stroked paths as a separate commit and then the split into various xyzOp structures.

I am not completely happy with this v3 though:
- it's way too easy to forget a clip.xyzOp
- it's a bit more verbose
- I've kept the clip.Path.Close (but made a mental note of the need to get rid of it for a v4)

ie: it's more of a WIP, plea for comments than anything else.

cheers,
-s

Signed-off-by: Sebastien Binet <s@sbinet.org>
---
 font/opentype/opentype.go                     |   5 +-
 gpu/dash.go                                   |  64 ++--
 gpu/gpu.go                                    | 159 ++++++---
 gpu/stroke.go                                 |  18 +-
 internal/opconst/ops.go                       |  14 +-
 internal/ops/reader.go                        |   6 -
 internal/rendertest/clip_test.go              | 327 +++++++++++-------
 .../refs/TestStrokedPathFlatMiter.png         | Bin 2309 -> 2258 bytes
 .../refs/TestStrokedPathFlatMiterInf.png      | Bin 2304 -> 2262 bytes
 internal/rendertest/render_test.go            |  10 +-
 op/clip/clip.go                               |  75 ++--
 op/clip/shapes.go                             |  15 +-
[message trimmed]

Signed-off-by: Sebastien Binet <s@sbinet.org>
---
 gpu/dash.go                                   | 392 ++++++++++++++++++
 gpu/gpu.go                                    |   6 +
 gpu/stroke.go                                 |  44 ++
 internal/opconst/ops.go                       |   2 +-
 internal/ops/reader.go                        |   6 +
 internal/rendertest/clip_test.go              | 264 +++++++-----
 .../refs/TestDashedPathFlatCapEllipse.png     | Bin 0 -> 6107 bytes
 .../refs/TestDashedPathFlatCapZ.png           | Bin 0 -> 3681 bytes
 .../refs/TestDashedPathFlatCapZNoDash.png     | Bin 0 -> 2262 bytes
 .../refs/TestDashedPathFlatCapZNoPath.png     | Bin 0 -> 1553 bytes
 op/clip/clip.go                               |   8 +-
 op/clip/stroke.go                             |  11 +-
[message trimmed]

On Monday, November 16th, 2020 at 4:56 PM, Elias Naur <mail@eliasnaur.com> wrote:

> On Mon Nov 16, 2020 at 14:23, Sebastien Binet wrote:
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > >
> > > On Sunday, November 15th, 2020 at 11:33 AM, Elias Naur <mail@eliasnaur.com> wrote:

[...]

> > under the new API, I believe it would look like that:
> >

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

>
> On Sunday, November 15th, 2020 at 11:33 AM, Elias Naur <mail@eliasnaur.com> wrote:
>
> > With the addition of DashesOp it seems the clip.Op is becoming a bit
> > convoluted. I suggest we split up clipping similar to how painting is
> > split between setting the brush (ImageOp, ColorOp) and applying it
> > (PaintOp).
> >
> > For clip, there is the defining of the path, filling it (path, stroke,
> > stroke style, dashes), and applying the clip.
> >

On Sunday, November 15th, 2020 at 11:33 AM, Elias Naur <mail@eliasnaur.com> wrote:

> With the addition of DashesOp it seems the clip.Op is becoming a bit
> convoluted. I suggest we split up clipping similar to how painting is
> split between setting the brush (ImageOp, ColorOp) and applying it
> (PaintOp).
>
> For clip, there is the defining of the path, filling it (path, stroke,
> stroke style, dashes), and applying the clip.
>
> In other words, I suggest
>
> 	package clip

then, boxes it is :)

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Saturday, November 14th, 2020 at 2:40 PM, Joop Kiefte <ikojba@gmail.com> wrote:

> > here is a simple program that draws random lines.
>
> as I am working on a port of my command line tetris game to a Gui, I
>
> am mostly interested in drawing colored boxes :P
>
> -------------------------------------------------------------------------------------------------------------------------
>

> On Fri Nov 13, 2020 at 6:03 PM CET, Sebastien Binet wrote:
> > Signed-off-by: Sebastien Binet <s@sbinet.org>
> > ---
> >  gpu/dash.go                                   | 392 ++++++++++++++++++
> >  gpu/gpu.go                                    |   6 +
> >  gpu/stroke.go                                 |  44 ++
> >  internal/opconst/ops.go                       |   2 +-
> >  internal/ops/reader.go                        |   6 +
> >  internal/rendertest/clip_test.go              | 264 +++++++-----
> >  .../refs/TestDashedPathFlatCapEllipse.png     | Bin 0 -> 6107 bytes
> >  .../refs/TestDashedPathFlatCapZ.png           | Bin 0 -> 3681 bytes
> >  .../refs/TestDashedPathFlatCapZNoDash.png     | Bin 0 -> 2262 bytes
> >  .../refs/TestDashedPathFlatCapZNoPath.png     | Bin 0 -> 1553 bytes
> >  op/clip/clip.go                               |   8 +-

hi,

here is a simple program that draws random lines.

hth,
-s

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Saturday, November 14th, 2020 at 4:06 AM, Joop Kiefte <ikojba@gmail.com> wrote:

> I'm getting a bit lost. I created a Flex Layout and would like to drop
>
> it in there. How does that fit?

Signed-off-by: Sebastien Binet <s@sbinet.org>
---
 gpu/dash.go                                   | 392 ++++++++++++++++++
 gpu/gpu.go                                    |   6 +
 gpu/stroke.go                                 |  44 ++
 internal/opconst/ops.go                       |   2 +-
 internal/ops/reader.go                        |   6 +
 internal/rendertest/clip_test.go              | 264 +++++++-----
 .../refs/TestDashedPathFlatCapEllipse.png     | Bin 0 -> 6107 bytes
 .../refs/TestDashedPathFlatCapZ.png           | Bin 0 -> 3681 bytes
 .../refs/TestDashedPathFlatCapZNoDash.png     | Bin 0 -> 2262 bytes
 .../refs/TestDashedPathFlatCapZNoPath.png     | Bin 0 -> 1553 bytes
 op/clip/clip.go                               |   8 +-
 op/clip/stroke.go                             |  11 +-
[message trimmed]