~sbinet

France

Particle physicist turned software engineer

~sbinet/dev

Last active 2 months ago

~sbinet/go-hep

Last active 5 months ago

~sbinet/star-tex

Last active 1 year, 3 months ago

~sbinet/vgogh

Last active 1 year, 8 months ago

~sbinet/star-tex-patches

Last active 2 years ago
View more

Recent activity

Re: Applied: [PATCH aerc v3] commands/msg: use selected message part for quote-reply and forward 9 days ago

From Sebastien Binet to ~rjarry/aerc-devel

On Wed Feb 14, 2024 at 14:24 CET, inwit wrote:
>
>
> On 17/01/2024, 11:59, Robin Jarry wrote:
> > Sebastien Binet <s@sbinet.org> wrote:
> > > use the currently selected message part (if any) as the original message
> > > for quote-reply and forward.
> > > honor viewer::alternatives if no message part was selected.
>
> Is there a way to disable this behaviour, at least for attachments? It
> is kinda annoying when you reply to a message while an attachment is
> selected and this attachment it's a binary file of some sort... I'd have
> expected a flag in the reply/forward commands. Sorry for not pointing
> this out while the patch was being reviewed.

Re: [PATCH aerc v1] commands/msg: only select non-attachment part for reply/forward 9 days ago

From Sebastien Binet to ~rjarry/aerc-devel

On Wed Feb 14, 2024 at 16:24 CET, Bence Ferdinandy wrote:
>
> On Wed Feb 14, 2024 at 15:02, Sebastien Binet <s@sbinet.org> wrote:
> > Modify getMessagePart to only return selected message part if it
> > isn't an attachment, to prevent accidentally quoting a (possibly)
> > binary attachment file.
> >
>
> Can't we detect instead if it is a binary file? I actually see the merit in
> replying to say an attached README.md. Although in that case you might need
> parts of text/html as well ... For that you probably need to pipe the message
> part to your clipboard and insert in the composer.

is there any agreed upon criteria for deciding a file is binary ?

Re: Applied: [PATCH aerc v3] commands/msg: use selected message part for quote-reply and forward 9 days ago

From Sebastien Binet to ~rjarry/aerc-devel

On Wed Feb 14, 2024 at 14:24 CET, inwit wrote:
>
>
> On 17/01/2024, 11:59, Robin Jarry wrote:
> > Sebastien Binet <s@sbinet.org> wrote:
> > > use the currently selected message part (if any) as the original message
> > > for quote-reply and forward.
> > > honor viewer::alternatives if no message part was selected.
>
> Is there a way to disable this behaviour, at least for attachments? It
> is kinda annoying when you reply to a message while an attachment is
> selected and this attachment it's a binary file of some sort... I'd have
> expected a flag in the reply/forward commands. Sorry for not pointing
> this out while the patch was being reviewed.

[PATCH aerc v1] commands/msg: only select non-attachment part for reply/forward 9 days ago

From Sebastien Binet to ~rjarry/aerc-devel

Modify getMessagePart to only return selected message part if it
isn't an attachment, to prevent accidentally quoting a (possibly)
binary attachment file.

Signed-off-by: Sebastien Binet <s@sbinet.org>
---
 commands/msg/utils.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/commands/msg/utils.go b/commands/msg/utils.go
index d6dffd50..022e79bf 100644
--- a/commands/msg/utils.go
+++ b/commands/msg/utils.go
@@ -63,7 +63,8 @@ func (h *helper) messages() ([]*models.MessageInfo, error) {
[message trimmed]

Re: [PATCH aerc v2] commands/msg: use selected message part for quote-reply and forward a month ago

From Sebastien Binet to ~rjarry/aerc-devel

On Wed Jan 10, 2024 at 19:56 CET, Bence Ferdinandy wrote:
>
> On Wed Jan 10, 2024 at 19:44, Sebastien Binet <s@sbinet.org> wrote:
> > On Tue Jan 9, 2024 at 18:30 CET, Bence Ferdinandy wrote:
> > >
> > > This will be useful! What will happen if I'm on say an image?
> >
> > it will do what is being asked :}
> > quote-reply the current part, ie: quote-reply the image content
>
> Isn't there a possibility of breaking the terminal if that happens?

I've just tried quote-replying to a mail with a mp4 as attachment (yeah... don't get me started...) and that didn't break my terminal.

Re: [PATCH aerc v2] commands/msg: use selected message part for quote-reply and forward a month ago

From Sebastien Binet to ~rjarry/aerc-devel

On Tue Jan 9, 2024 at 18:30 CET, Bence Ferdinandy wrote:
>
> On Tue Jan 09, 2024 at 14:53, Sebastien Binet <s@sbinet.org> wrote:
> > use the currently selected message part (if any) as the original message
> > for quote-reply and forward.
> > honor viewer::alternatives if no message part was selected.
> >
> > Signed-off-by: Sebastien Binet <s@sbinet.org>
> > ---
>
> This will be useful! What will happen if I'm on say an image?

it will do what is being asked :}
quote-reply the current part, ie: quote-reply the image content

[PATCH aerc v3] commands/msg: use selected message part for quote-reply and forward a month ago

From Sebastien Binet to ~rjarry/aerc-devel

use the currently selected message part (if any) as the original message
for quote-reply and forward.
honor viewer::alternatives if no message part was selected.

Signed-off-by: Sebastien Binet <s@sbinet.org>
---
 commands/msg/forward.go |  3 ++-
 commands/msg/reply.go   |  9 +--------
 commands/msg/utils.go   | 15 +++++++++++++++
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/commands/msg/forward.go b/commands/msg/forward.go
index 4147e8c..20e945c 100644
--- a/commands/msg/forward.go
[message trimmed]

Re: [PATCH aerc v2] commands/msg: use selected message part for quote-reply and forward a month ago

From Sebastien Binet to ~rjarry/aerc-devel

On Tue Jan 9, 2024 at 15:50 CET, Koni Marti wrote:
> On Tue Jan 9, 2024 at 1:53 PM UTC, Sebastien Binet wrote:
> > use the currently selected message part (if any) as the original message
> > for quote-reply and forward.
> > honor viewer::alternatives if no message part was selected.
> >
> > Signed-off-by: Sebastien Binet <s@sbinet.org>
> > ---
>
> Thanks for v2. Tested both with :reply and :forward and it works well.
>
> >  commands/msg/forward.go | 23 ++++++++++++++++++++++-
> >  commands/msg/reply.go   | 23 ++++++++++++++++++-----
> >  2 files changed, 40 insertions(+), 6 deletions(-)

[PATCH aerc v2] commands/msg: use selected message part for quote-reply and forward a month ago

From Sebastien Binet to ~rjarry/aerc-devel

use the currently selected message part (if any) as the original message
for quote-reply and forward.
honor viewer::alternatives if no message part was selected.

Signed-off-by: Sebastien Binet <s@sbinet.org>
---
 commands/msg/forward.go | 23 ++++++++++++++++++++++-
 commands/msg/reply.go   | 23 ++++++++++++++++++-----
 2 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/commands/msg/forward.go b/commands/msg/forward.go
index 4147e8c..4b65086 100644
--- a/commands/msg/forward.go
+++ b/commands/msg/forward.go
[message trimmed]

Re: [PATCH aerc] commands/msg: use selected message part for quote-reply a month ago

From Sebastien Binet to ~rjarry/aerc-devel

On Tue Jan 9, 2024 at 08:22 CET, Koni Marti wrote:
> On Mon Jan 8, 2024 at 5:04 PM CET, Sebastien Binet wrote:
> > From: Sebastien Binet <s@sbinet.org>
> >
> > use the currently selected message part (if any) as the original message for quote-reply.
> > honor viewer::alternatives if no message part was selected.
> >
> > Signed-off-by: Sebastien Binet <s@sbinet.org>
> > ---
>
> Hi Sebastien, thanks for the patch. Looks good to me.
>
> Do you think it would make sense to add the same logic to the :forward
> command [1] as well (for equivalence)?