~scoopta/wofi

1

Re: [PATCH] add --no-osk,-K flag to optionally disable triggering sm.puri virt keyboard via dbus

Details
Message ID
<CAKRGxTGUQnLsdK6DVvuacJAfv8==FwQzHvy+qswRhm9KkEsZDQ@mail.gmail.com>
DKIM signature
pass
Download raw message
I used `hg export -o wofi-no-osk.patch -r tip`

Going to try to attach ithe export file right now.

Re: [PATCH] add --no-osk,-K flag to optionally disable triggering sm.puri virt keyboard via dbus

Scoopta
Details
Message ID
<5b913df9-2b0c-16b6-bf54-793a4a809085@scoopta.email>
In-Reply-To
<CAKRGxTGUQnLsdK6DVvuacJAfv8==FwQzHvy+qswRhm9KkEsZDQ@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
This fixes the issue in that I can now import the patch, that being said 
I'm not going to push it without the corresponding documentation.

 From my original reply:

"A few notes on the patch in general aside from the failure. When adding
command line options to wofi you should additionally add a print to the
--help output inside of print_usage() as well as adding the option to
the wofi(1) man pages and the corresponding no_osk config option to the
wofi(5) man pages. These changes should be placed in the same order as
the option definition in the code, that is between --no-actions and
--define since that is where you put the option code."
Reply to thread Export thread (mbox)