~scoopta/wofi

2 2

Re: [PATCH] add --no-osk,-K flag to optionally disable triggering sm.puri virt keyboard via dbus

Details
Message ID
<CAKRGxTGeC60RFb9LE=B+eps8CZoaDLDJwAeQ48SDE80F+cRgRA@mail.gmail.com>
DKIM signature
pass
Download raw message
Here's a second patch updating wofi.1 and print_usage. I did it under
a different commit and am unsure how to merge... still new to
mercurial. If this is acceptable, great! If not I'll dig in more.

Re: [PATCH] add --no-osk,-K flag to optionally disable triggering sm.puri virt keyboard via dbus

Scoopta
Details
Message ID
<b0eb7312-12fd-2d8a-59b6-27b89f74b1e5@scoopta.email>
In-Reply-To
<CAKRGxTGeC60RFb9LE=B+eps8CZoaDLDJwAeQ48SDE80F+cRgRA@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
You can use hg commit --amend to commit against your previous commit 
instead of making a separate one. That being said I'm fine with a 
separate patch set however a few things to note about this patch. First 
your --help print lists -a as the shorthand for --no-osk which is 
incorrect. Second thing is you need to add .TP above your .B line in the 
man edit as right now --no-osk is being strung onto the same line as 
--no-actions (run man ./man/wofi.1 to see what I mean). Third and final, 
please add no_osk config documentation to wofi(5). (This is basically 
just copy and paste from your wofi(1) changes with a few tweaks to 
formatting for config options)

Re: [PATCH] add --no-osk,-K flag to optionally disable triggering sm.puri virt keyboard via dbus

Details
Message ID
<CAKRGxTHe2nKeiwYBEBQR8=n3jVhWV816peG6_PqbhgvSjntQfA@mail.gmail.com>
In-Reply-To
<b0eb7312-12fd-2d8a-59b6-27b89f74b1e5@scoopta.email> (view parent)
DKIM signature
pass
Download raw message
Will try that. Thanks for all the pointers!

On Sat, Oct 16, 2021 at 11:41 PM Scoopta <scoopta@scoopta.email> wrote:
>
> You can use hg commit --amend to commit against your previous commit
> instead of making a separate one. That being said I'm fine with a
> separate patch set however a few things to note about this patch. First
> your --help print lists -a as the shorthand for --no-osk which is
> incorrect. Second thing is you need to add .TP above your .B line in the
> man edit as right now --no-osk is being strung onto the same line as
> --no-actions (run man ./man/wofi.1 to see what I mean). Third and final,
> please add no_osk config documentation to wofi(5). (This is basically
> just copy and paste from your wofi(1) changes with a few tweaks to
> formatting for config options)
>
>
Reply to thread Export thread (mbox)