i didn't do a pull for a while now, but the latest commit seems to break the
compilation. do you maby have not commited your local changes?

cc -c -D_XOPEN_SOURCE=700 -Wall -Wno-format -g -std=c11 -pedantic `sdl2-config --cflags` `pkg-config --cflags lua5.4` -o main.o main.c
main.c: In function 'lock_tetromino':
main.c:1814:38: error: 'old_board' undeclared (first use in this function)
1814 |                 try_write_game_state(old_board, true);
     |                                      ^~~~~~~~~
main.c:1814:38: note: each undeclared identifier is reported only once for each function it appears in
main.c: In function 'gametick':
main.c:4983:61: error: 'BOARD_TOPOUT' undeclared (first use in this function)
4983 |                         && (state.game.online_p2.board[0] & BOARD_TOPOUT) == 0) {
     |                                                             ^~~~~~~~~~~~
main.c:5046:44: error: 'BOARD_LINECLEAR' undeclared (first use in this function); did you mean 'SFX_LINECLEAR'?
5046 |                                 if ((row & BOARD_LINECLEAR) != 0) {
     |                                            ^~~~~~~~~~~~~~~
     |                                            SFX_LINECLEAR

my grammar is actually horrible, sorry ;-)

i hope you can read it lol

ah, whoops. i have some unpushed unfinished commits that overhaul online
mode; apparently the most recent commit depended on that accidentally. i
reverted it, it should compile now. thanks for the heads up!

btw semi-unrelated, but would you be ok if i re-licensed generic
tetromino game from GPL3 to WTFPL? i'm asking because you've contributed
in the past so this would relicense your contribution

> btw semi-unrelated, but would you be ok if i re-licensed generic
> tetromino game from GPL3 to WTFPL? i'm asking because you've contributed
> in the past so this would relicense your contribution

all of these 8000+ lines of code, which are really impressive btw., are all
your own work and i just contributed a small fix about something that
annoyed me. of course, i am fine with that.

but why would you want to do this? i think one of the big advantages of GPLv3 is
that it forces people (especially companies) to make their changes open source
and it kinda protects your clone of NES tetris from comercial exploitation. idk,
in the end it's your decision, just asking.

- Lorenz

ps: sorry for the spam, i messed stuff up.

On Mon May 8, 2023 at 5:44 AM EDT, Lorenz wrote:
> but why would you want to do this? i think one of the big advantages of GPLv3 is
> that it forces people (especially companies) to make their changes open source
> and it kinda protects your clone of NES tetris from comercial exploitation. idk,
> in the end it's your decision, just asking.

Well I'm not super concerned about commercial exploitation of an NES
Tetris clone, for one. I've recently been changing my opinions about
licensing in general, with regards to permissive/restrictive licensing
and copyleft and all that. I'm still not entirely settled on an opinion,
this is one of those things where I can definitely see all the
viewpoints, and I think they're all valid. I guess I can't really give a
good explanation as to why I want generic tetromino game in the public
domain? But it just feels right. I might regret this later lol, who
knows.