~sebsite/generic-tetromino-game

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH v2] Colors: add BLACK

Lorenz (xha) <me@xha.li>
Details
Message ID
<20230523021924.4886-1-me@xha.li>
DKIM signature
missing
Download raw message
Patch: +8 -0
---
v2: docs :)

 main.c                      | 3 +++
 website/docs/api/index.html | 5 +++++
 2 files changed, 8 insertions(+)

diff --git a/main.c b/main.c
index 4db7e27..47db79d 100644
--- a/main.c
+++ b/main.c
@@ -70,6 +70,7 @@
#define INPUT_MASK_START (1 << 6)
#define INPUT_MASK_REPEAT (1 << 7)

#define BLACK 0x00000000
#define WHITE 0xffffffff
#define GREEN 0x287200ff
#define RED 0x982220ff
@@ -6856,6 +6857,8 @@ init_lua(void)
	lua_seti(L, -2, EV_TOPOUT);
	lua_setfield(L, -2, "__useroptions");
	lua_createtable(L, 0, 0); /* game.color */
	lua_pushinteger(L, (lua_Integer)BLACK);
	lua_setfield(L, -2, "BLACK");
	lua_pushinteger(L, (lua_Integer)WHITE);
	lua_setfield(L, -2, "WHITE");
	lua_pushinteger(L, (lua_Integer)GREEN);
diff --git a/website/docs/api/index.html b/website/docs/api/index.html
index 3b26dc5..2c0938b 100644
--- a/website/docs/api/index.html
+++ b/website/docs/api/index.html
@@ -327,6 +327,11 @@
          <p>Literally just white. idk why i'm even documenting this
          <pre><code><a href="#game" class="code-ref">game</a>.color.WHITE: integer</code></pre>
        </section>
	<section id="game-color-BLACK">
	  <h3><a href="#game-color-BLACK">game.color.BLACK</a></h3>
	  <p>It's exactly what you think it is
	  <pre><code><a href="#game" class="code-ref">game</a>.color.BLACK: integer</code></pre>
	</section>
        <section id="game-color-YELLOW">
          <h3><a href="#game-color-YELLOW">game.color.YELLOW</a></h3>
          <p>A yellow color from the NES color palette.
-- 
2.40.1
Details
Message ID
<CSTBNA30THED.EBIDTKI5SQNZ@notmylaptop>
In-Reply-To
<20230523021924.4886-1-me@xha.li> (view parent)
DKIM signature
missing
Download raw message
On Mon May 22, 2023 at 10:19 PM EDT, Lorenz (xha) wrote:
> +	<section id="game-color-BLACK">
> +	  <h3><a href="#game-color-BLACK">game.color.BLACK</a></h3>
> +	  <p>It's exactly what you think it is
> +	  <pre><code><a href="#game" class="code-ref">game</a>.color.BLACK: integer</code></pre>
> +	</section>

tbh since now there's both WHITE and BLACK I think they should just be
documented as "the color white" and "the color black" respectively. I
forgot I added that "idk why i'm even documenting this" thing to WHITE
lol, but it doesn't work quite as well with BLACK also being a thing.
Yeah I'm overanalyzing docs that don't actually matter at all lol, the
actual issue here is that the docs should be alphabetized, so BLACK
should come before all the other colors.

Sorry I'm being so pedantic about this btw, it would just really bother
me if it wasn't alphabetized when everything else is lol
Reply to thread Export thread (mbox)