~shugyousha

~shugyousha/public-inbox

Last active 3 years ago
View more

Recent activity

Re: [PATCH] lua: complete-word: stay in current mode 20 days ago

From Silvan Jegen to ~martanne/devel

Florian Fischer <florian.fischer@muhq.space> wrote:
> Completing word causes vis to exit insert mode, since we changed
> complete-words to use vis' regex in 004800e348cba1bf5f4536876b4e0eafbcf1ea58.
> 
> Simply remember the current mode and restore it after the completion.

LGTM!

Cheers,
Silvan

> ---
>  lua/plugins/complete-word.lua | 3 +++
>  1 file changed, 3 insertions(+)

Re: [PATCH vis] (void *) shouldn't be parameter of snprintf. 20 days ago

From Silvan Jegen to ~martanne/devel

Matěj Cepl <mcepl@cepl.eu> wrote:
> We should specify what kind of data are send to snprintf even at
> least as (char *).
> ---
> OK, I am not certain with this one. Is it (char *) or (CommandDef *)?

The man page for "snprintf" says that it takes a (char *), so I think
the patch is correct.

Cheers,
Silvan


> 

Re: [PATCH] vis-complete: split words using awk(1) instead of tr(1) a month ago

From Silvan Jegen to ~martanne/devel

Florian Fischer <florian.fischer@muhq.space> wrote:
> Similar to d3e4af1f0a33849b36196b035fddf64037e0c282 the
> lack of unicode support in GNU's tr(1) implementation prevents
> word completions for word containing unicode glyphs.
> 
> Apparently, most awk implementations support unicode.
> 
> Signed-off-by: Florian Fischer <florian.fischer@muhq.space>

LGTM, thanks for the patch!

Cheers,
Silvan

Re: [PATCH vis] vis-complete: split words using awk(1) instead of tr(1) a month ago

From Silvan Jegen to ~martanne/devel

Florian Fischer <florian.fischer@muhq.space> wrote:
> Similar to d3e4af1f0a33849b36196b035fddf64037e0c282 the
> lack of unicode support in GNU's tr(1) implementation prevents
> word completions for word containing unicode glyphs.
> 
> Apparently, most awk implementations support unicode.

Thanks for the patch!

I'm a bit confused because your patch description is mentioning "awk"
but your patch is using "sed" ...

I have tried both a version with and without your patch and in both
cases I could autocomplete the Polish text in your coverletter.

Re: [PATCH] Fixes theme after add Cc and Bcc fields 2 months ago

From Silvan Jegen to ~migadu/alps-devel

Heyhey

> After adding the fields Cc and Bcc the box to drag and drop the
> attachments was misaligned, with this change it occupies again all the
> available space.
> ---
>  themes/alps/assets/style.css | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM!
 

> diff --git a/themes/alps/assets/style.css b/themes/alps/assets/style.css
> index 13b04fa..b0d6eb8 100644

Re: Forgotten PR? redraw after mode change to ensure visual effects are changed 4 months ago

From Silvan Jegen to ~martanne/devel

Randy Palamar <randy@rnpnr.xyz> wrote:
> "Silvan Jegen" <me@sillymon.ch> wrote:
> > Matěj Cepl <mcepl@cepl.eu> wrote:
> > > https://github.com/martanne/vis/pull/769
> > > 
> > > I think it should be rather trivial yea-or-nay
> > > decision and it is the last item on the TODO list in
> > > https://github.com/martanne/vis/issues/1001, which could be then
> > > truly done.
> > 
> > For what it's worth, this LGTM!
> > 
> > I have added my review on Github as well.
> > 

Re: Forgotten PR? redraw after mode change to ensure visual effects are changed 4 months ago

From Silvan Jegen to ~martanne/devel

Matěj Cepl <mcepl@cepl.eu> wrote:
> https://github.com/martanne/vis/pull/769
> 
> I think it should be rather trivial yea-or-nay
> decision and it is the last item on the TODO list in
> https://github.com/martanne/vis/issues/1001, which could be then
> truly done.

For what it's worth, this LGTM!

I have added my review on Github as well.

Cheers,
Silvan

Re: [PATCH vis v3] lua: add a plugin to implement the `gf` command 6 months ago

From Silvan Jegen to ~martanne/devel

Heyhey

Matěj Cepl <mcepl@cepl.eu> wrote:
> From: Silvan Jegen <s.jegen@gmail.com>
> 
> This plugin implements the "gf" command of vim as a lua plugin, which
> tries to open a file having the same name as the string currently under
> the primary cursor. It recognises the filenames in the following cases.
> 
> vis.c
> vis.c:222 (opens file at specific line offset)
> vis.c:/goto (opens file at first match of search pattern after '/')
> 
> This patch is a rework of the following Github PR and supersedes it.

Re: [PATCH v2] lua: add a plugin to implement the `gf` command 7 months ago

From Silvan Jegen to ~martanne/devel

Hi Randy

Randy Palamar <palamar@ualberta.ca> wrote:
> On Mon, Sep 11, 2023 at 12:28 PM Silvan Jegen <s.jegen@gmail.com> wrote:
> >
> > This plugin implements the "gf" command of vim as a lua plugin, which
> > tries to open a file having the same name as the string currently under
> > the primary cursor. It recognises the filenames in the following cases.
> >
> > vis.c
> > vis.c:222 (opens file at specific line offset)
> > vis.c:/goto (opens file at first match of search pattern after '/')
> >
> > This patch is a rework of the following Github PR and supersedes it.

Re: [PATCH] lua: add a plugin to implement the `gf` command 7 months ago

From Silvan Jegen to ~martanne/devel

Matěj Cepl <mcepl@cepl.eu> wrote:
> On Mon Sep 11, 2023 at 1:25 PM CEST, Silvan Jegen wrote:
> > I may be misremembering but I think the "<c-w>gf" command opens
> > files in new tabs while the one without the "g" opens them in
> > a new window.
> 
> I haven’t even knew that CTRL-W_gf and CTRL-W_gF existed, I have
> never used them. Given that there are no real tabs and windows
> (in the vim/nvim meaning of the word), and our windows looks more
> splits in vim/nvim, I would probably prefer CTRL-W_f.

I have sent a new version of the patch with this change.

Cheers,