Hi

On Wed, Mar 05, 2025 at 03:59:27PM -0500, Aren wrote:
> > diff --git a/scripts/core/sxmo_keyboard_autorotate.sh b/scripts/core/sxmo_keyboard_autorotate.sh
> > deleted file mode 100755
> > index dbf03e7..0000000
> > --- a/scripts/core/sxmo_keyboard_autorotate.sh
> > +++ /dev/null
> > @@ -1,26 +0,0 @@
> > -#!/bin/sh
> > -# SPDX-License-Identifier: AGPL-3.0-only
> > -# Copyright 2022 Sxmo Contributors
> > -
> > -# shellcheck source=scripts/core/sxmo_common.sh

On Tue, Feb 04, 2025 at 09:19:18AM -0800, Anjandev Momi wrote:
> 
> 
> On Tue Jan 28, 2025 at 11:05 PM PST, Sicelo A. Mhlongo wrote:
> > Since sxmo_init.sh is stored in the profile.d/ directory, it gets run even when
> > the user has purposely disabled sxmo, e.g. because they are running another DE.
> > It is therefore better to not print anything to the terminal when the script
> > determines that sxmo is not running.
> 
> I dont think this is a good idea. If this error is annoying and the user
> wants to disable sxmo, the user should uninstall sxmo-utils or ignore
> this error.

Alright

e55d30d2adcf ("Auto rotate screen on physical keyboard opened/closed") uses the
keyboard slider state to do autorotation. However, it always forces portrait
orientation when the keyboard slider is closed, which is not necessarily
desirable.

Improve the use of the keyboard slider by allowing accelerometer-based rotation
normally, and forcing normal orientation when the slider is out. This also
matches the behavior in the stock OSes of devices with such a slider, e.g.
Maemo Leste on the N900 and Android on the Motorola Droid 4. Slider being out
forced the landscape orientation regardless of the user selection, while
portrait mode respected the user choice. This makes sense since you cannot
really use the keyboard while the device is in portrait mode.

Signed-off-By: Sicelo A. Mhlongo <absicsz@gmail.com>
[message trimmed]

Since sxmo_init.sh is stored in the profile.d/ directory, it gets run even when
the user has purposely disabled sxmo, e.g. because they are running another DE.
It is therefore better to not print anything to the terminal when the script
determines that sxmo is not running.

Signed-off-by: Sicelo A. Mhlongo
---
 configs/profile.d/sxmo_init.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/profile.d/sxmo_init.sh b/configs/profile.d/sxmo_init.sh
index 6dbd46c..e5cb42b 100644
--- a/configs/profile.d/sxmo_init.sh
+++ b/configs/profile.d/sxmo_init.sh
[message trimmed]

91d4319df559 ("sway: add config for Nokia N900") added a new sway mode
to cater for the limitations imposed by the Nokia N900's physical
keyboard. At least one user reported a conflict with their keybinds.
Drop the mode and its binding from the global configuration. It can be
moved to a device-specific configuration, and be stored under
/etc/sway/config.d/* per sway's default/global include directive

Fixes: 91d4319df559 ("sway: add config for Nokia N900")
Fixes: https://lists.sr.ht/~mil/sxmo-devel/patches/53195

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 configs/appcfg/sway_template | 18 ------------------
 1 file changed, 18 deletions(-)
[message trimmed]

Define TOUCHSCREEN_ID so the touchscreen can be reliably disabled when device
is in locked state. When undefined, in some cases it does not get disabled,
causing wakeups.

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh b/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
index 08ab216..2545be9 100644
--- a/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
@@ -5,6 +5,7 @@
[message trimmed]

Fix merged

Issue can be closed now.

While the N900 has a hardware keyboard, it only has a few keys. A virtual keyboard is still very useful to have. Some symbols, especially emoji, cannot be typed easily from hardware keyboard. Hence, restore access to the virtual keyboard using the VolDown key.

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh b/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
index fb686c6..08ab216 100644
--- a/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
@@ -15,6 +15,5 @@ export SXMO_ROTATE_DIRECTION="left"
 export SXMO_KEYBOARD_SLIDER_EVENT_DEVICE="/dev/input/by-path/platform-gpio_keys-event"
 export SXMO_KEYBOARD_SLIDER_CLOSE_EVENT="*code 10 (SW_KEYPAD_SLIDE), value 0*"
[message trimmed]

default dmenu lines are too long for N900's tiny screen. reduce to fit

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh b/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
index ef0d81f..b61895f 100644
--- a/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh
@@ -9,6 +9,8 @@ export SXMO_SWAY_SCALE="1.5"
 #on N900 these two are swaped
 export SXMO_BEMENU_LANDSCAPE_LINES="10"
[message trimmed]

Commit 4913fac4ee0a ("Cleanup virtual keyboard management") introduced
SXMO_NO_KEYBOARD environment variable to disable virtual keyboard. Rename so
this purpose is clear/obvious from the name.

Drop the variable on Nokia N900, since virtual keyboard is still useful on it,
e.g. for emoji.

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 configs/default_hooks/sxmo_hook_inputhandler.sh             | 6 +++---
 scripts/core/sxmo_keyboard.sh                               | 2 +-
 scripts/deviceprofiles/README.md                            | 2 +-
 scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh        | 2 +-
 .../deviceprofiles/sxmo_deviceprofile_nokia,omap3-n900.sh   | 1 -
[message trimmed]