This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH sgx-jmp] Disambiguate user input for enabling unlimited ringing

Message ID
DKIM signature
Download raw message
Patch: +1 -1

Hi singpolyma,

This patch updates the user message so that it is clear what the user should input exactly.

I accidentally was entering Negative. I was also wondering if -2, -3, etc was allowed.

This patch should disambiguate what the user is expected to input.

What do you think?

all best,


 forms/configure_calls.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/forms/configure_calls.rb b/forms/configure_calls.rb
index b225d71..3c0eeab 100644
--- a/forms/configure_calls.rb
+++ b/forms/configure_calls.rb
@@ -14,7 +14,7 @@ if @customer.fwd.voicemail_enabled?
		type: "text-single",
		datatype: "xs:integer",
		label: "Seconds to ring before voicemail",
		description: "One ring is ~5 seconds. Negative means ring forever.",
		description: "One ring is ~5 seconds. -1 means ring forever.",
		value: @customer.fwd.timeout.to_i.to_s


[sgx-jmp/patches] build failed

builds.sr.ht <builds@sr.ht>
Message ID
<20231204211812.139155-1-jgart@dismail.de> (view parent)
DKIM signature
Download raw message
sgx-jmp/patches: FAILED in 3m0s

[Disambiguate user input for enabling unlimited ringing][0] from [jgart][1]

[0]: https://lists.sr.ht/~singpolyma/dev/patches/47378
[1]: jgart@dismail.de

✗ #1107649 FAILED sgx-jmp/patches/ubuntu-lts.yml    https://builds.sr.ht/~singpolyma/job/1107649
✗ #1107648 FAILED sgx-jmp/patches/debian-stable.yml https://builds.sr.ht/~singpolyma/job/1107648
Reply to thread Export thread (mbox)