~singpolyma/dev

1

[Pull request] Minor nit in custom theme management

Details
Message ID
<87v8iq3a0n.fsf@ccss.com>
DKIM signature
missing
Download raw message
Patch: +1 -1
Fix ArrayIndexOutOfBoundsException at ColorResourcesTableCreator.java:616.
Details and stack trace in commit message.

The following changes since commit 3737b013f03bad59b54e04b62aaedc33d62c5aa5:

  Tags haven't been "read-only" for awhile (2023-03-23 18:42:02 -0500)

are available in the Git repository at:

  git@git.sr.ht:~hdasch/cheogram-android color-resources

for you to fetch changes up to bdafe2ca8f95fc8702d07008838140f09191bf1d:

  Fix ColorResourcesTableCreator creation exception. (2023-03-23 23:57:37 -0700)

----------------------------------------------------------------
Hugh Daschbach (1):
      Fix ColorResourcesTableCreator creation exception.

 src/cheogram/java/com/cheogram/android/ColorResourcesTableCreator.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cheogram/java/com/cheogram/android/ColorResourcesTableCreator.java b/src/cheogram/java/com/cheogram/android/ColorResourcesTableCreator.java
index 1a0620e46..59807aa6a 100644
--- a/src/cheogram/java/com/cheogram/android/ColorResourcesTableCreator.java
+++ b/src/cheogram/java/com/cheogram/android/ColorResourcesTableCreator.java
@@ -77,7 +77,7 @@ final class ColorResourcesTableCreator {
      colorResource =
          new ColorResource(
              entry.getKey(),
              context.getResources().getResourceName(entry.getKey()),
              context.getResources().getResourceEntryName(entry.getKey()),
              entry.getValue());
      if (!context
          .getResources()

Re: [Singpolyma-Dev] [Pull request] Minor nit in custom theme management

Details
Message ID
<ZCHTnWDwuUQOCXie@singpolyma-beefy.lan>
In-Reply-To
<87v8iq3a0n.fsf@ccss.com> (view parent)
DKIM signature
missing
Download raw message
>Fix ArrayIndexOutOfBoundsException at ColorResourcesTableCreator.java:616.
>Details and stack trace in commit message.
>
>-              context.getResources().getResourceName(entry.getKey()),
>+              context.getResources().getResourceEntryName(entry.getKey()),

Thanks so much for this!  This code was pretty blindly copied from inside 
some Material You guts and I never understood the every-three problem.  Very 
happy to merge this fix.
Reply to thread Export thread (mbox)