Agreed.

Pushed all of your pending patches. Thanks!

To git@git.sr.ht:~sircmpwn/gddo
   324246f..3c6bcec  master -> master

On Tue Jan 26, 2021 at 5:29 PM EST, Adnan Maolood wrote:
> Let the browser handle cache busting on its own.

NACK. Appending the version is a useful mechanism for indicating that
content has changed, and failing to signal that can lead to broken
pages. The browser can still cache with this approach - but this
prevents it from caching now invalid assets.

On SourceHut we do this better by putting the sha256sum of the asset
into its URL. If you're seeking an improvement, something along those
lines of thought would work better.

Though, if the opportunity to improve the markup presents itself while
we're working on proximate patches, doing so in small, incremental
amounts seems like a good idea to me.

Probably not worth prioritizing right now, I don't think. With godocs.io
I simply want to take the torch from godoc.org and make gradual,
conservative improvements. We shouldn't overhaul it any more than is
necessary for it to work well, except in gradual, measured steps which
are careful to preserve the spirit of the original.

I think the more urgent priorities are functional improvements, such as
Go module support or addressing fetch package subdirectories
automatically (tickets #1 and #2).

I'm not sure that this change is desirable for the time being. It
doesn't remove stale components or move away from something closed
source or otherwise problematic. It just changes something for its own
sake, which is not a conservative departure from the original gddo
codebase. Can you explain in more detail why you think this change is
necessary?

Thanks!

To git@git.sr.ht:~sircmpwn/gddo
   3c6bcec..bb4e83d  master -> master

Thanks!

To git@git.sr.ht:~sircmpwn/gddo
   bb4e83d..1af1acc  master -> master

Thanks!

To git@git.sr.ht:~sircmpwn/gddo
   1af1acc..4b86bb4  master -> master

Still does not apply.