~sircmpwn/aerc

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] widgets/terminal: Reap more zombies

Details
Message ID
<20191121192440.40777-1-keur@xcf.berkeley.edu>
DKIM signature
missing
Download raw message
Patch: +1 -0
The editor and pager were not properly being reaped, causing resource
leakage whenever a user replies to a message.

Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu>
---
 widgets/terminal.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/widgets/terminal.go b/widgets/terminal.go
index 6ad6904..bbe7f82 100644
--- a/widgets/terminal.go
+++ b/widgets/terminal.go
@@ -180,6 +180,7 @@ func (term *Terminal) Close(err error) {
 	}
 	if term.cmd != nil && term.cmd.Process != nil {
 		term.cmd.Process.Kill()
+		term.cmd.Wait()
 		term.cmd = nil
 	}
 	if !term.closed && term.OnClose != nil {
--
2.24.0
Details
Message ID
<BYP4RGR0N3UV.2TODI44Z8Z380@homura>
In-Reply-To
<20191121192440.40777-1-keur@xcf.berkeley.edu> (view parent)
DKIM signature
pass
Download raw message
Thanks!

To git.sr.ht:~sircmpwn/aerc
   eff8208..06f81e8  master -> master