~sircmpwn/aerc

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
11 3

[PATCH] Add aerc.desktop

Details
Message ID
<20200518125159.76070-1-d.masserut@gmail.com>
DKIM signature
pass
Download raw message
Patch: +15 -0
---

 Makefile     |  4 ++++
 aerc.desktop | 11 +++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 aerc.desktop

diff --git a/Makefile b/Makefile
index 3f06c4d..7f2f9e0 100644
--- a/Makefile
+++ b/Makefile
@@ -10,6 +10,7 @@ _INSTDIR=$(DESTDIR)$(PREFIX)
BINDIR?=$(_INSTDIR)/bin
SHAREDIR?=$(_INSTDIR)/share/aerc
MANDIR?=$(_INSTDIR)/share/man
DESKTOPDIR?=$(_INSTDIR)/share/applications
GO?=go
GOFLAGS?=

@@ -79,6 +80,7 @@ install: all
	install -m755 filters/plaintext $(SHAREDIR)/filters/plaintext
	install -m644 templates/quoted_reply $(SHAREDIR)/templates/quoted_reply
	install -m644 templates/forward_as_body $(SHAREDIR)/templates/forward_as_body
	install -m644 aerc.desktop $(DESKTOPDIR)/aerc.desktop

RMDIR_IF_EMPTY:=sh -c '\
if test -d $$0 && ! ls -1qA $$0 | grep -q . ; then \
@@ -98,11 +100,13 @@ uninstall:
	$(RM) $(MANDIR)/man7/aerc-tutorial.7
	$(RM) $(MANDIR)/man7/aerc-templates.7
	$(RM) -r $(SHAREDIR)
	$(RM) $(DESKTOPDIR)/aerc.desktop
	${RMDIR_IF_EMPTY} $(BINDIR)
	$(RMDIR_IF_EMPTY) $(MANDIR)/man1
	$(RMDIR_IF_EMPTY) $(MANDIR)/man5
	$(RMDIR_IF_EMPTY) $(MANDIR)/man7
	$(RMDIR_IF_EMPTY) $(MANDIR)
	$(RMDIR_IF_EMPTY) $(DESKTOPDIR)

.DEFAULT_GOAL := all

diff --git a/aerc.desktop b/aerc.desktop
new file mode 100644
index 0000000..d25c14a
--- /dev/null
+++ b/aerc.desktop
@@ -0,0 +1,11 @@
[Desktop Entry]
Name=aerc
GenericName=Email Client
Comment=A pretty good email client
Exec=aerc %u
MimeType=x-scheme-handler/mailto;
MimeType=message/rfc822;x-scheme-handler/mailto;application/x-xpinstall;
Icon=emblem-mail
Terminal=true
Type=Application
Categories=Network;Email;
--
2.26.2
Details
Message ID
<C2TVBUVMHP3H.3LDKZT4N63JR0@homura>
In-Reply-To
<20200518125159.76070-1-d.masserut@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Sorry, no thanks.
Details
Message ID
<C2TVDFQ4ML4O.R7GHGT4JL0LC@T480s>
In-Reply-To
<C2TVBUVMHP3H.3LDKZT4N63JR0@homura> (view parent)
DKIM signature
pass
Download raw message
Why?
Details
Message ID
<C864X0H65YG5.1ZWZ4KRR4M37@fedora-desktop>
In-Reply-To
<C2TVBUVMHP3H.3LDKZT4N63JR0@homura> (view parent)
DKIM signature
missing
Download raw message
On Mon May 18, 2020 at 2:53 PM CEST, Drew DeVault wrote:
> Sorry, no thanks.

Is there any real problem with adding this? Is it something technically
problematic?
Details
Message ID
<C864X2F6ZJTI.3RPXJCDXWBMNL@taiga>
In-Reply-To
<C864X0H65YG5.1ZWZ4KRR4M37@fedora-desktop> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
No, but it's not desirable nevertheless.
Details
Message ID
<C864Z04AI3B2.34CU0TKSN85KM@fedora-desktop>
In-Reply-To
<C864X2F6ZJTI.3RPXJCDXWBMNL@taiga> (view parent)
DKIM signature
missing
Download raw message
On Wed Dec 30, 2020 at 1:56 PM CET, Drew DeVault wrote:
> No, but it's not desirable nevertheless.

I would like to use aerc to xdg-open mailto links. Without a desktop
file, I don't have that possibility.

It would be nice to at least have the option to include the desktop
file, in, let's say, the Makefile via an env or something, don't you
think?
Details
Message ID
<C864YXMC1IZK.3G6TC643UFE7S@taiga>
In-Reply-To
<C864Z04AI3B2.34CU0TKSN85KM@fedora-desktop> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Wed Dec 30, 2020 at 7:58 AM EST, Robin Opletal wrote:
> I would like to use aerc to xdg-open mailto links. Without a desktop
> file, I don't have that possibility.
>
> It would be nice to at least have the option to include the desktop
> file, in, let's say, the Makefile via an env or something, don't you
> think?

No. Your use-case is not desirable to support. Either install a desktop
file yourself in $HOME or rig up a wrapper for xdg-open, the latter is
what I do.
Details
Message ID
<C8650X3QJWVA.RQJPKNW7VP2E@fedora-desktop>
In-Reply-To
<C864YXMC1IZK.3G6TC643UFE7S@taiga> (view parent)
DKIM signature
missing
Download raw message
On Wed Dec 30, 2020 at 1:59 PM CET, Drew DeVault wrote:
>
> No. Your use-case is not desirable to support. Either install a desktop
> file yourself in $HOME or rig up a wrapper for xdg-open, the latter is
> what I do.

I would like to know what the problem with having a desktop file is.
Details
Message ID
<C8650J51W0NP.2HEQY3AI2XLAC@taiga>
In-Reply-To
<C8650X3QJWVA.RQJPKNW7VP2E@fedora-desktop> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
You are not entitled to an answer.
Details
Message ID
<C86534B1ZC93.2SLCBU7QKJGN6@fedora-desktop>
In-Reply-To
<C8650J51W0NP.2HEQY3AI2XLAC@taiga> (view parent)
DKIM signature
missing
Download raw message
On Wed Dec 30, 2020 at 2:01 PM CET, Drew DeVault wrote:
> You are not entitled to an answer.

I don't demand an answer, I am genuinly curious to know what the problem
is, nothing else.
Details
Message ID
<C8653XCI9THF.17PTF5H0CWGNL@fedora-desktop>
In-Reply-To
<C8650J51W0NP.2HEQY3AI2XLAC@taiga> (view parent)
DKIM signature
missing
Download raw message
On Wed Dec 30, 2020 at 2:01 PM CET, Drew DeVault wrote:
> You are not entitled to an answer.

If there are other usability issues that you have with having the
desktop file, it would also be nice to know what those issues are. I
really am just trying to understand what the problem with this is.
Details
Message ID
<C8653FXMF5R6.HNFWPJX2BAAA@taiga>
In-Reply-To
<C86534B1ZC93.2SLCBU7QKJGN6@fedora-desktop> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Wed Dec 30, 2020 at 8:03 AM EST, Robin Opletal wrote:
> I don't demand an answer, I am genuinly curious to know what the problem
> is, nothing else.

No feature is free. Everything incurs a maintenance cost, and the
feature has to be valuable enough to justify it. This is not.
Reply to thread Export thread (mbox)