---
 commands/msgview/save.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index 7649a5f..375be96 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -181,10 +181,10 @@ func generateFilename(part *models.BodyStructure) string {
 	if fn, ok := part.DispositionParams["filename"]; ok {
 		filename = fn
 	} else if fn, ok := part.Params["name"]; ok {
-                filename = fn
-        }
-        // Used to handle "/", "." and ".." in filenames correctly
-        filename = filename[strings.LastIndex(filename, "/")+1:]
+		filename = fn
+	}
+	// Used to handle "/", "." and ".." in filenames correctly
+	filename = filename[strings.LastIndex(filename, "/")+1:]
 	if filename == "" || filename == "." || filename == ".." {
 		timestamp := time.Now().Format("2006-01-02-150405")
 		filename = fmt.Sprintf("aerc_%v", timestamp)
--
2.29.2

Hi Robin,
Thanks for the patch.
However it does not seem to apply for me... is this the latest patch?
There were some hiccups along the way I think, care to resend?

On Thu, Jan 07, 2021 at 11:57:21AM +0100, Robin Opletal wrote:
> ---
>  commands/msgview/save.go | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/commands/msgview/save.go b/commands/msgview/save.go
> index 7649a5f..375be96 100644
> --- a/commands/msgview/save.go
> +++ b/commands/msgview/save.go
> @@ -181,10 +181,10 @@ func generateFilename(part *models.BodyStructure) string {
>  	if fn, ok := part.DispositionParams["filename"]; ok {
>  		filename = fn
>  	} else if fn, ok := part.Params["name"]; ok {
> -                filename = fn
> -        }
> -        // Used to handle "/", "." and ".." in filenames correctly
> -        filename = filename[strings.LastIndex(filename, "/")+1:]
> +		filename = fn
> +	}
> +	// Used to handle "/", "." and ".." in filenames correctly
> +	filename = filename[strings.LastIndex(filename, "/")+1:]
>  	if filename == "" || filename == "." || filename == ".." {
>  		timestamp := time.Now().Format("2006-01-02-150405")
>  		filename = fmt.Sprintf("aerc_%v", timestamp)
> --
> 2.29.2
> 

Cheers,
Reto

On Tue Jan 12, 2021 at 9:31 PM CET, Reto wrote:
> Hi Robin,
> Thanks for the patch.
> However it does not seem to apply for me... is this the latest patch?
> There were some hiccups along the way I think, care to resend?

Hi Reto, thank you for reviewing the patch.

Yeah, I am not quite used to using git-send-email yet. Have to spend
some more time with it to get comfortable.

I am thinking what the best way would be to send both of the commits
that I have made as a single patch? Probably send it as a "new" patch
without any annotate?

Thanks for the advice,
Robin

On Tue, Jan 12, 2021 at 09:35:31PM +0100, Robin Opletal wrote:
> Yeah, I am not quite used to using git-send-email yet. Have to spend
> some more time with it to get comfortable.

Maybe https://git-send-email.io/ helps?

> I am thinking what the best way would be to send both of the commits
> that I have made as a single patch? Probably send it as a "new" patch
> without any annotate?

Ehm, which two commits?
Wasn't it just a single change that you made, the one with the save path being
garbage?

If you mean some other feature, you need to send that as a separate patch.
The way patch sets work is that they should bundle commits of a single "feature"

If they are unrelated, send two patches.
The above link should show you how.

Kind regards,
Reto

On Tue Jan 12, 2021 at 9:55 PM CET, Reto wrote:

> Maybe https://git-send-email.io/ helps?

Thanks - went through it once, should probably rinse and repeat.

> If you mean some other feature, you need to send that as a separate
> patch.
> The way patch sets work is that they should bundle commits of a single
> "feature"

It's the same patch, with a fix in a second commit which, instead of
ammending to the previous commit I have made another commit.

I have now rebased the two into one and sent a clear path that should
work fine

Best regards,
Robin