~sircmpwn/aerc

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH] Remove `-s` from PageUp/PageDown binds

Details
Message ID
<20210806184747.14844-1-fossdd@pwned.life>
DKIM signature
missing
Download raw message
Patch: +2 -2
From: fossdd <fossdd@pwned.life>

Pressing PageUp or PageDown with the default keybindings, it showed the
manual of how `prev` and `next` works.

Looks like there is not a `-s` implementation which was used previosly
used by PageUp/PageDown.
---
 config/binds.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/binds.conf b/config/binds.conf
index abfd77e..7ee4d74 100644
--- a/config/binds.conf
+++ b/config/binds.conf
@@ -12,13 +12,13 @@ j = :next<Enter>
<Down> = :next<Enter>
<C-d> = :next 50%<Enter>
<C-f> = :next 100%<Enter>
<PgDn> = :next -s 100%<Enter>
<PgDn> = :next 100%<Enter>

k = :prev<Enter>
<Up> = :prev<Enter>
<C-u> = :prev 50%<Enter>
<C-b> = :prev 100%<Enter>
<PgUp> = :prev -s 100%<Enter>
<PgUp> = :prev 100%<Enter>
g = :select 0<Enter>
G = :select -1<Enter>

-- 
2.32.0
Details
Message ID
<CDSQUB7OS6FX.HI87XDCCPD8L@ARCHe-Moritz>
In-Reply-To
<20210806184747.14844-1-fossdd@pwned.life> (view parent)
DKIM signature
missing
Download raw message
I don't think it's useful to have the same effect bound to two keys. I
get that changing the default behaviour might confuse a part of the
userbase, but I'd personally opt for removing the Page Up/Down bindings
from the default keybindings. If someone needs them, they can just
re-add them. I feel like most users will probably go through their
config at least once.
Details
Message ID
<CDSS19JIIRIK.1E98WUYWGDG63@main>
In-Reply-To
<CDSQUB7OS6FX.HI87XDCCPD8L@ARCHe-Moritz> (view parent)
DKIM signature
missing
Download raw message
Why would you remove them. Page Up/Down are keys in configures in nearly
all applications and is imo easier as <C-b>.

BTW: There also other duplicated binds like the next field on composing:
<C-j> and <tab>. Removing here the tab also is weird for many users ig.
Details
Message ID
<CDSSIN4JVKF0.1S5IKLP2HV7FZ@ARCHe-Moritz>
In-Reply-To
<CDSS19JIIRIK.1E98WUYWGDG63@main> (view parent)
DKIM signature
missing
Download raw message
> Why would you remove them. Page Up/Down are keys in configures in nearly
> all applications and is imo easier as <C-b>.

Duplicated keybinds tend to cause confusion (at least they cause
frequent calls to the support department where I work).
I agree that PgUp/Down is probably more user-friendly than C-b and it's
ultimately up to the user

> BTW: There also other duplicated binds like the next field on composing:
> <C-j> and <tab>. Removing here the tab also is weird for many users ig.

Just on another note: removing any keybinding here does not affect your
user experience, because the binds.conf is in your userdir. I am also
for removing this duplicate, but this is not part of this patch.

I am also not of the opinion that my opinion is the be-all and end-all,
so feel free to reason with me here :D
Reply to thread Export thread (mbox)