Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by mail.sr.ht (Postfix) with ESMTPS id 511FD40178 for <~sircmpwn/aerc@lists.sr.ht>; Sun, 30 Jun 2019 03:05:33 +0000 (UTC) Received: from localhost (p5DE3B7DF.dip0.t-ipconnect.de [93.227.183.223]) (Authenticated sender: robert@gnzler.io) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7FF73100003; Sun, 30 Jun 2019 03:05:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable To: "Drew DeVault" , =?utf-8?q?Robert_G=C3=BCnzler?= , <~sircmpwn/aerc@lists.sr.ht> In-Reply-To: From: "Robert Guenzler" Date: Sun, 30 Jun 2019 05:05:28 +0200 Subject: Re: [PATCH] Remove dirs field and references to it Message-Id: Content-Type: text/plain; charset=UTF-8 On Sat Jun 29, 2019 at 10:30 PM Drew DeVault wrote: > Hmm, prev/next-folder works fine for me. it does? I just tried with a clean build from master and default configs and still no luck... and looking at the code in `widget/dirlist.go` I don't understand how it can work? The loop in `nextPrev` only looks at the `dirlist.dirs` but that field never even gets initialized or updated. `UpdateList` only puts new directories it finds into the new store. This was part of Greg's patch series for completion support, could I be missing some part of it for some weird reason...?