~sircmpwn/aerc

1

Re: [PATCH v6] Account Specific Bindings

Details
Message ID
<YKe0svUCTHRihaWE@divine-infinity-black-hole-gamma-lap>
DKIM signature
pass
Download raw message
I have tested this patch and have found it to be working as expected. I
have one documentation nitpick though.

> +*[context:account=regex]*
> +	keybindings for this context and account, where *regex* matches
> +	the account name provided in *accounts.conf*

The term 'regex' could be confusing. I am saying this because I got
derailed during testing this patch. I got over-excited when I saw the
term regex and did not read the rest of the manual text. My first test
configuration was a negative lookahead for a Google account since I had
already configured the GMail bindings globally earlier. When it did not
work after a couple of tries, is when I went back to the manual to read
the rest of the documentation to find the catch - 'where *regex* matches
the account name provided in *accounts.conf*'

The parameter is expected to 'matches the account name provided in
*accounts.conf*' which means it has to be exactly what is provided in
accounts.conf.

In that case, the parameter should be named `<AccountName>`. That would
match the parameter in the UI configuration as well. It should be
assumed that people are already familiar with the UI configuration and
would naturally expect this configuration to be similar.

Since aerc also supports regex-based configuration in the UI context,
and since this configuration does not support regexes, we should avoid
usage of the term 'regex' in the documentation too.

Also, would it be a good idea to throw some kind of a warning when the
account specified in the configuration is not found? It could either be
misconfigured or a typo in the configuration. This is possible only when
the configuration does not support regexes.

Re: [PATCH v6] Account Specific Bindings

Jonathan Bartlett
Details
Message ID
<CBJ1OR1KWMP2.2AQ4L4TA9NFH9@jblp>
In-Reply-To
<YKe0svUCTHRihaWE@divine-infinity-black-hole-gamma-lap> (view parent)
DKIM signature
pass
Download raw message
> In that case, the parameter should be named `<AccountName>`. That would
> match the parameter in the UI configuration as well. It should be
> assumed that people are already familiar with the UI configuration and
> would naturally expect this configuration to be similar.

Yeah, I agree that `<AccountName>` is more intuitive and will change
this for v7 of the patch.

>
> Also, would it be a good idea to throw some kind of a warning when the
> account specified in the configuration is not found? It could either be
> misconfigured or a typo in the configuration. This is possible only when
> the configuration does not support regexes.

I am happy to add this too.

Thanks for your feedback,

Jonathan.
Reply to thread Export thread (mbox)