Fix in-reply-to with <> in the mailto: url. v1 PROPOSED

James Walmsley: 1
 Fix in-reply-to with <> in the mailto: url.

 1 files changed, 5 insertions(+), 0 deletions(-)

[PATCH] Fix in-reply-to with <> in the mailto: url. Export this patch

My first experience writing to this list, I replied using the
'Reply to thread' button, and when I sent the mail it unexpectedly
created a new thread.

I found that the go-message library (SetMsgIDList()) assumes that the <>
tags are not present. So I ended up with a header like:

```
in-reply-to: <<message-id@lists...>>
```

(Perhaps this should be a patch to go-message?)

If Aerc should handle this situation then here is my proposed patch that
has solved the issue for me.

I've never used golang before, so there maybe a better way to do this
happy to be shown :)

Best

James

Reto

6 days ago

When you send an email with git send-email whatever you write up here, prior to the
`---` line below would end up in the commit message

Next

---

Reto

6 days ago

So if you want to add some additional commentary, not relevant for the commit message
itself, add it here. And by here I mean after the `---` but before the diffstat
that follows just after this sentence.

Next

 widgets/aerc.go | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/widgets/aerc.go b/widgets/aerc.go
index 70bee7c..4ba7ef4 100644
--- a/widgets/aerc.go
+++ b/widgets/aerc.go
@@ -514,6 +514,11 @@ func (aerc *Aerc) Mailto(addr *url.URL) error {
 			}
 			h.SetAddressList("Cc", list)
 		case "in-reply-to":
+			for  i, val:= range vals {
+				if(strings.HasPrefix(val, "<") && strings.HasSuffix(val, ">")) {
+					vals[i] = val[1:len(val)-1]
+				}
+			}
 			h.SetMsgIDList("In-Reply-To", vals)
 		case "subject":
 			subject = strings.Join(vals, ",")
--
2.25.1

Reto

6 days ago

Other than that, your patch is malformed.
Go uses `go fmt` to format whitespace and align things. You should always run
it prior to sending a patch.

Further, HasPrefix / HasSuffix is a bit expensive in our case... we now that we
only want a single rune so we might as well check for this.

I've essentially copied the code already existing in the imap worker in
0e554a879d1b8de61e6eb7d2e7ef64e9ec99ce1b and added you as co-author.

Thanks for the effort and sorry for the late response.

Kind regards,
Reto

Reto

6 days ago

Hi,
Thanks for the patch, some comments:

On Fri, Jan 01, 2021 at 06:40:40PM +0000, James Walmsley wrote: