Nguyễn Gia Phong: 2
Stop wrapping OriginalText in default templates
Remove redundant toLocal as format includes TZ
3 files changed, 3 insertions(+), 3 deletions(-)
Not sure I follow your reasoning:
```
package main
import (
"fmt"
"log"
"time"
)
func main() {
format := "Mon Jan 2, 2006 at 3:04 PM MST"
date := time.Now()
fmt.Println(date.Format(format)) // Fri Mar 26, 2021 at 5:52 PM CET
loc, err := time.LoadLocation("MST")
if err != nil {
log.Fatalf("%#v", err)
}
mstDate := date.In(loc)
fmt.Println(mstDate.Format(format)) // Fri Mar 26, 2021 at 9:52 AM MST
}
```
The TZ in the format string just instructs go to add the TZ string, it doesn't
impact what TZ the date is actually in, *that's* what toLocal does in aerc.
Or am I missing what you actually want to achieve?
Cheers,
Reto
Thank you for the explanation, there was some mistake when I was
experimenting with it. Does the parent commit make sense though,
and should I resend the patch without this child commit?
I don't think so, no.
It's easy enough to change the default if you don't like it.
I personally don't like force wrapping either, that's something the client should
do, not the sender as only the client knows the display size.
Drew is in the other camp though.
Cheers,
Reto
The problem with wrap is that it tries to split the orignal message
by whitespace, which makes quoted patches differs from the original.
I noticed this by that lists.sr.ht cannot automatically display
where the review is supposed to be.
That being said, my local template without wrapping is working fine,
and the change is trivial, I see no reason pushing for it any further.
Cheers.