~sircmpwn/aerc

Remove `-s` from PageUp/PageDown binds v1 PROPOSED

: 1
 Remove `-s` from PageUp/PageDown binds

 1 files changed, 2 insertions(+), 2 deletions(-)
Why would you remove them. Page Up/Down are keys in configures in nearly
all applications and is imo easier as <C-b>.
BTW: There also other duplicated binds like the next field on composing:
<C-j> and <tab>. Removing here the tab also is weird for many users ig.

Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/aerc/patches/24224/mbox | git am -3
Learn more about email & git
View this thread in the archives

[PATCH] Remove `-s` from PageUp/PageDown binds Export this patch

From: fossdd <fossdd@pwned.life>

Pressing PageUp or PageDown with the default keybindings, it showed the
manual of how `prev` and `next` works.

Looks like there is not a `-s` implementation which was used previosly
used by PageUp/PageDown.
---
 config/binds.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/binds.conf b/config/binds.conf
index abfd77e..7ee4d74 100644
--- a/config/binds.conf
+++ b/config/binds.conf
@@ -12,13 +12,13 @@ j = :next<Enter>
<Down> = :next<Enter>
<C-d> = :next 50%<Enter>
<C-f> = :next 100%<Enter>
<PgDn> = :next -s 100%<Enter>
<PgDn> = :next 100%<Enter>

k = :prev<Enter>
<Up> = :prev<Enter>
<C-u> = :prev 50%<Enter>
<C-b> = :prev 100%<Enter>
<PgUp> = :prev -s 100%<Enter>
<PgUp> = :prev 100%<Enter>
g = :select 0<Enter>
G = :select -1<Enter>

-- 
2.32.0
I don't think it's useful to have the same effect bound to two keys. I
get that changing the default behaviour might confuse a part of the
userbase, but I'd personally opt for removing the Page Up/Down bindings
from the default keybindings. If someone needs them, they can just
re-add them. I feel like most users will probably go through their
config at least once.