~sircmpwn/aerc

lib/msgstore: fix invalid callback invocation v1 PROPOSED

Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/aerc/%3C20191009074601.12942-1-reto%40labrat.space%3E/mbox | git am -3
Learn more about email & git

[PATCH] lib/msgstore: fix invalid callback invocation Export this patch

creating a directory must not invoke the callback, as this is meant for the
completion of the move

---
 lib/msgstore.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/msgstore.go b/lib/msgstore.go
index b0392ba..2d9d5b9 100644
--- a/lib/msgstore.go
+++ b/lib/msgstore.go
@@ -293,7 +293,7 @@ func (store *MessageStore) Move(uids []uint32, dest string, createDest bool,
 		store.worker.PostAction(&types.CreateDirectory{
 			Directory: dest,
 			Quiet:     true,
-		}, cb)
+		}, nil) // quiet doesn't return an error, don't want the done cb here
 	}
 
 	store.worker.PostAction(&types.CopyMessages{
-- 
2.23.0
View this thread in the archives