~sircmpwn/aerc

widgets/terminal: Reap more zombies v1 PROPOSED

Kevin Kuehler: 1
 widgets/terminal: Reap more zombies

 1 files changed, 1 insertions(+), 0 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/aerc/patches/9110/mbox | git am -3
Learn more about email & git

[PATCH] widgets/terminal: Reap more zombies Export this patch

The editor and pager were not properly being reaped, causing resource
leakage whenever a user replies to a message.

Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu>
---
 widgets/terminal.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/widgets/terminal.go b/widgets/terminal.go
index 6ad6904..bbe7f82 100644
--- a/widgets/terminal.go
+++ b/widgets/terminal.go
@@ -180,6 +180,7 @@ func (term *Terminal) Close(err error) {
 	}
 	if term.cmd != nil && term.cmd.Process != nil {
 		term.cmd.Process.Kill()
+		term.cmd.Wait()
 		term.cmd = nil
 	}
 	if !term.closed && term.OnClose != nil {
--
2.24.0
Thanks!

To git.sr.ht:~sircmpwn/aerc
   eff8208..06f81e8  master -> master
View this thread in the archives