~sircmpwn/alpine-aports (mirror)

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 3

[PATCH] community/iwd: remove outdated flag

Pranjal Kole <pranjal.kole7@gmail.com>
Details
Message ID
<20220309144113.10196-1-pranjal.kole7@gmail.com>
DKIM signature
missing
Download raw message
2 years ago
Patch: +0 -1 
This flag is ignored by ./configure
---
 community/iwd/APKBUILD | 1 -
 1 file changed, 1 deletion(-)

diff --git a/community/iwd/APKBUILD b/community/iwd/APKBUILD
index 41fbcdf397..2cff522b49 100644
--- a/community/iwd/APKBUILD
+++ b/community/iwd/APKBUILD
@@ -35,7 +35,6 @@ build() {
		--mandir=/usr/share/man \
		--localstatedir=/var \
		--disable-systemd-service \
		--enable-sim-hardcoded \
		--enable-wired \
		--enable-tools
	make
-- 
2.35.1
<Milan P.Stanić>
Details
Message ID
<164683724818.985.10635282075560460550.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local>
In-Reply-To
<20220309144113.10196-1-pranjal.kole7@gmail.com> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
this is not worth merge request. opening issue/bug report is enough

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31825#note_221177
alice <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<164684180207.985.13244915080794986034.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local>
In-Reply-To
<164683724818.985.10635282075560460550.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
sure, but you can also press merge, and it's solved for you :p

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31825#note_221181
<Michał Polański>
Details
Message ID
<164684744468.985.15885932968839280573.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local>
In-Reply-To
<164684180207.985.13244915080794986034.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
> this is not worth merge request

This is very much worth a merge request. You're discouraging users from contributing to Alpine with that attitude.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31825#note_221197
<Milan P.Stanić>
Details
Message ID
<164690924792.985.13638565848946072497.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local>
In-Reply-To
<164684744468.985.15885932968839280573.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
@mpolanski so you think reporting bug/issue is not contribution?

Though I'm not against merging this

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31825#note_221351
<Michał Polański>
Details
Message ID
<164696003531.985.3294767805253615989.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local>
In-Reply-To
<164690924792.985.13638565848946072497.gitlab.31825.019195a88b02d98f228c00882923f532f259daa7@listserv.local> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
> so you think reporting bug/issue is not contribution?

Somebody has put in an effort in making a merge request and by saying that "this is not worth merge request" you're diminishing their work. Certainly, it's not like opening an issue about a problem is any less valuable.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31825#note_221483
Reply to thread Export thread (mbox)